- 19 Feb, 2020 5 commits
-
-
Robert Knight authored
Do not set "aria-pressed" attribute for non-toggle buttons
-
Robert Knight authored
Setting the `aria-pressed` attribute on a button indicates to assistive technology that it is a toggle button. Because the `Button` component always set this attribute and the `isActive` prop had a default value of false, this meant that every `Button` in the UI was identified as a toggle button by screen readers. Fix the issue by renaming `isActive` to `isPressed` and aligning it with the behavior of `aria-pressed`: - If `true`, the button is a pressed toggle button - If `false`, the button is a non-pressed toggle button - If undefined, the button is a regular button and `aria-pressed` is not set
-
Robert Knight authored
Add accessible label to annotation body markdown editor
-
Robert Knight authored
Extract repeated references to editor text string into a variable to make it more obvious how different statements in the test are connected.
-
Robert Knight authored
Add accessible label to search input field
-
- 18 Feb, 2020 3 commits
-
-
Robert Knight authored
Bump postcss from 7.0.26 to 7.0.27
-
dependabot-preview[bot] authored
Bumps [babel-plugin-mockable-imports](https://github.com/robertknight/babel-plugin-mockable-imports) from 1.7.0 to 1.7.1. - [Release notes](https://github.com/robertknight/babel-plugin-mockable-imports/releases) - [Changelog](https://github.com/robertknight/babel-plugin-mockable-imports/blob/master/CHANGELOG.md) - [Commits](https://github.com/robertknight/babel-plugin-mockable-imports/compare/v1.7.0...v1.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.26 to 7.0.27. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/7.0.26...7.0.27) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 17 Feb, 2020 12 commits
-
-
Robert Knight authored
Bump preact from 10.3.1 to 10.3.2
-
Robert Knight authored
Bump axe-core from 3.4.2 to 3.5.1
-
Robert Knight authored
Bump npm-packlist from 2.0.3 to 2.1.0
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.614.0 to 2.619.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.614.0...v2.619.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump request from 2.88.0 to 2.88.2
-
Robert Knight authored
The a11y test failures were fixed in 2c96ef64.
-
dependabot-preview[bot] authored
Bumps [request](https://github.com/request/request) from 2.88.0 to 2.88.2. - [Release notes](https://github.com/request/request/releases) - [Changelog](https://github.com/request/request/blob/master/CHANGELOG.md) - [Commits](https://github.com/request/request/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 3.4.2 to 3.5.1. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-core/compare/v3.4.2...v3.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.3.1 to 10.3.2. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.3.1...10.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 2.0.3 to 2.1.0. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Commits](https://github.com/npm/npm-packlist/compare/v2.0.3...v2.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
In my testing with screen readers the meaning was reasonably clear from the fact that you had to click on a button labeled "Search annotations" to focus the field and there is a "Search..." placeholder. Nevertheless, this keeps automated checking tools happy. A better solution would probably be to re-design the search UI so that there is enough space for a visible label and information about the search syntax, as well as enough space for the search field on smaller screens.
-
Robert Knight authored
Visually I think the purpose of this field is obvious without an explicit label but it may not be clear to assistive tech users.
-
- 14 Feb, 2020 6 commits
-
-
Kyle Keating authored
Fix a11y for LoggedOutMessage
-
Robert Knight authored
Enable debugging info for JSX elements in dev builds and tests
-
Lyza Gardner authored
Add reply capability to service, `AnnotationOmega`
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Refactor `SidebarContentError` for a11y, usability
-
- 13 Feb, 2020 14 commits
-
-
Kyle Keating authored
Add `flex-shrink` rule to login links
-
Kyle Keating authored
Force 4.5:1 contrast on css Change <a> link to <Button> —since it acts like a button
-
Lyza Danger Gardner authored
Refactor `SidebarContentError` to be simpler and provide a clearer UX for the four possible states of direct-linked errors (states are based on error type—annotation or group—and whether the user is logged in or not). Reuse sidebar-panel design pattern overall. Provide an option for the user to “clear the error”, i.e., show all annotations instead of “filtering” by the direct-linked annotation or group. Provide a button for the user to log in if they are not currently logged in. Update `SearchStatusBar` to remove unneeded references to direct-linked store information, as it will now not render if there is a direct-linked error.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Add a `flex-shrink` rule to the login links in the `TopBar` component to assure that they don’t get all squished up when a search is active.
-
Lyza Gardner authored
Replace link with `Button` in `AnnotationHeader` (A11y)
-
Lyza Danger Gardner authored
Fixes a11y-linting issue. Part of https://github.com/hypothesis/client/issues/1727
-
Kyle Keating authored
Fix AutocompleteList aria-selecterd prop
-
Kyle Keating authored
Fix a11y lint on SelectionTabs component
-
Kyle Keating authored
Fix a11y for Excerpt
-
Robert Knight authored
Remove jQuery dependency from highlighter and add test for multiple text nodes
-
Lyza Gardner authored
AnnotationOmega: Add very basic expand/collapse for reply threads
-
Robert Knight authored
As part of an ongoing project to remove the annotator's jQuery dependency, rewrite the highlighter to avoid it. This change is also preparation for some upcoming changes to make highlights more friendly for screen reader users by reducing the number of `<hypothesis-highlight>` elements created for a run of text in various situations. Since each `<hypothesis-highlight>` announces its presence to the screen reader, this gets "noisy" if there are many such elements.
-
Lyza Gardner authored
Convert ‘Log in’ and ‘Sign up’ links to `Button` components
-