1. 19 Feb, 2018 7 commits
  2. 18 Feb, 2018 1 commit
  3. 16 Feb, 2018 7 commits
  4. 15 Feb, 2018 1 commit
    • Sheetal Umesh Kumar's avatar
      Get the list of groups from the new endpoint and update it wherever applicable. · 36c46608
      Sheetal Umesh Kumar authored
      Fetch the list of groups from the new `/api/groups` endpoint instead of
      using the groups list returned in the `/api/profile` result. This
      supports providing the current document URI as a parameter, which
      enables the server to change the list of open groups returned depending
      on the current URL.
      
      In order to update the groups list correctly, taking into account the
      current document URI, when the user joins or leaves a group, the
      `streamer` service now handles "session change" notifications by
      triggering a re-fetch of groups from the `/api/groups` endpoint instead
      of updating the groups directly from the payload of the WebSocket
      message.
      Co-authored-by: 's avatarRobert Knight <robertknight@gmail.com>
      36c46608
  5. 13 Feb, 2018 4 commits
  6. 12 Feb, 2018 4 commits
    • Robert Knight's avatar
      Fix AnnotationController#delete test failure · e68aa1ab
      Robert Knight authored
      Fix a test failure due to a subtle issue with the interaction between
      the `$q` service, `AnnotationController#delete` and `$timeout.flush` in
      tests.
      
      Instantiating the rejected promise _before_ calling `$timeout.flush`
      resulted in Angular's unhandled promise checking code being triggered
      in the test.
      e68aa1ab
    • Robert Knight's avatar
      Fix "multilink" error in Angular 1.6.9 · 9d73f6d2
      Robert Knight authored
      Fix occurrences of a "multilink" [1] error during test for the
      annotation save button.
      
      Replace calls to the link function with direct assignments to controller
      properties.
      
      [1] https://code.angularjs.org/1.6.9/docs/error/$compile/multilink
      9d73f6d2
    • Robert Knight's avatar
      Update to Angular 1.6.9 · 50bd5d66
      Robert Knight authored
      The main change that affects us is that component inputs/bindings are no
      longer available as controller properties in the constructor by default.
      Instead this logic should go in a controller's `$onInit` method.
      
      In this commit use the `$compileProvider.preAssignBindingsEnabled`
      compatibility helper which preserves the Angular <= 1.5 behavior. This
      is being removed in Angular 1.7.
      50bd5d66
    • Robert Knight's avatar
      Fix spinner animation · 19ff5532
      Robert Knight authored
      `@keyframes($name)` is not legal syntax. I'm unsure if this ever worked
      in the past in older browsers or if it was previously converted by a
      post-processor to valid syntax.
      19ff5532
  7. 09 Feb, 2018 1 commit
  8. 06 Feb, 2018 1 commit
    • Robert Knight's avatar
      Refactor export of bound selectors from Redux store · dcf77f92
      Robert Knight authored
      Group the selectors in each Redux module together in a `selectors`
      object so they can be re-exported as methods on the Redux store without
      having to list each of them manually.
      
      This also just makes it easier to visually see which exported functions
      from a Redux module are selectors.
      dcf77f92
  9. 30 Jan, 2018 4 commits
  10. 29 Jan, 2018 1 commit
  11. 25 Jan, 2018 4 commits
  12. 24 Jan, 2018 2 commits
  13. 22 Jan, 2018 1 commit
    • Robert Knight's avatar
      Fix login flow triggering popup blocker in Firefox and IE · 7626dd65
      Robert Knight authored
      hypothesis/client#603 broke the login popup window in Firefox and IE
      because the call to `window.open` no longer happens in the same turn of
      the event loop as the user's click on the "Login" link. It is therefore
      no longer considered in FF to have happened "in response to a user
      gesture".
      
      This PR fixes the issue by separating creation and use of the popup
      window into separate functions and moving creation to happen earlier, in
      the same event loop turn as the "Login" button click.
      
      Fixes #534
      7626dd65
  14. 19 Jan, 2018 1 commit
    • katelyn's avatar
      Update README.md · 4da53b6a
      katelyn authored
      Now there are two separate links for requesting an invite to our public Slack workspace (slack.hypothes.is) and accessing the workspace once you already have an account (hypothesis-open.slack.com)
      4da53b6a
  15. 10 Jan, 2018 1 commit