- 11 May, 2016 4 commits
-
-
Robert Knight authored
This adds the initial infrastructure using Redux for centralizing the UI state as an immutable object accessible via `annotationUI.getState()` which is updated as a result of actions from the UI, network etc. For background on why we want to do this, see the design overview at https://github.com/hypothesis/h/pull/3176 Additionally this commit removes a couple of tests that checked for non-mutation of the selected/focused annotation maps and uses seamless-immutable instead which provides a better guarantee of this, but only in debug builds.
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
* Also remove duplicated variables in css.
-
Nick Stenning authored
Do not test annotation schema
-
- 10 May, 2016 7 commits
-
-
Sean Hammond authored
Convert h.script to a package
-
Nick Stenning authored
Views code for updating annotations in postgres
-
Robert Knight authored
* Add an 'h-tooltip' attribute directive which displays a tooltip above the associated element as soon as it is hovered and removes the tooltip on mouseout or when the associated element is destroyed. * Use the custom tooltip for buttons in the annotation card footer and remove the labels.
-
Nick Stenning authored
Move EventQueue into h.api and sandbox event notifies
-
Robert Knight authored
Remove extra margin set by first and last p in an annotation body.
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
Sheetaluk/336 reply threading
-
- 09 May, 2016 28 commits
-
-
Robert Knight authored
Change display of datetimes on annotations
-
Sheetal Umesh Kumar authored
* Change the background of bucket bar. * Change margins, line height, font size, default state colour and hover state colour for different elements in the annotation card and the replies thread. Trello cards: https://trello.com/c/aXCXxzx2/327-update-the-visual-design-of-the-annotation-cards https://trello.com/b/o2ungX1n/current-sprint
-
Sean Hammond authored
When dealing with more than one second, minute or hour display secs, mins or hrs instead of sec, min or hr. In the case of secs it's always more than 1.
-
Sean Hammond authored
-
Sean Hammond authored
The dates passed in to toFuzzyString() and nextFuzzyUpdate() are actually date strings and not (as in the tests) Date objects, but the code expects Date objects, so it crashes in production (but works fine in the tests). Fix both the production code and the tests to use date strings.
-
Sean Hammond authored
-
Sean Hammond authored
Make Intl an optional argument in time.js so that tests can pass in a mock Intl (or null) instead of having to patch window.Intl.
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
Clearer than using an array of arrays.
-
Sean Hammond authored
-
Sean Hammond authored
Clarify why we don't just call Date.toLocaleDateString().
-
Sean Hammond authored
getBreakpoint() always return a breakpoint.
-
Sean Hammond authored
If an annotation is more than one day old then it gets a timestamp like "09 May". The next time this timestamp would change would be on 1 Jan 2017 when it would change to "09 May 2016". Rather than setting a really long timer, just never live update "09 May"-format timestamps. The case where Hypothesis is left open without reloading a page until the end of the year, and the case where Hypothesis is opened close to midnight on Dec 31st, are obscure enough to ignore. If an annotation is not from the current year then it gets a timestamp like "14 March 2015". The format of this timestamp will always be the same, so don't set any timeout to update it.
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
toLocaleDateString() creates a new formatter on each call which is expensive.
-
Sean Hammond authored
These are used when the datetime in question is more than 24 hours ago but still in the current year, and when it's not in the current year, respectively. They replace a few different datestring formats that were previously being used for datetimes in this range.
-
Sean Hammond authored
This produces "1 days ago" which is wrong, will be fixed later.
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
In date strings on annotation cards.
-
Sean Hammond authored
In date string formatting functions. Will enable more diverse formatting.
-
Sean Hammond authored
In time.js replace format strings like '{} minutes ago' with functions like nMinutesAgo(delta) that return strings. The format strings only support datetime string formats of the type "n seconds/minutes/hours/days/months/years ago". Although we don't take advantage of it yet with format functions we can format datetime strings any way we want, for example "16 April" for a date more than 24 hours ago or "16 Apr 2016" for a date more than a year ago.
-
Sean Hammond authored
Although we're not taking advantage of it yet, this should allow us to use more complex logic such as "within the current year" to select a date format.
-
- 04 May, 2016 1 commit
-
-
Robert Knight authored
This is the first part of the new threading UI implementation whose design is outlined at https://github.com/hypothesis/h/pull/3176/ build-thread implements the logic for constructing an immutable view model for a list of conversations (a 'Thread') from a list of annotations and replies plus an object describing the current UI state. This view model is then rendered by an <annotation-thread> component. Once the other parts of the new implementation are ready, this will replace 'threading', 'thread-filter' and the JWZ script.
-