- 07 Jul, 2020 10 commits
-
-
Lyza Gardner authored
- Adjust a few related mixins - Adjust tests; make them less brittle on CSS classes - Fix arrow alignment for narrow viewports
-
Lyza Gardner authored
Fix layout of `AnnotationPublishControl` for Safari
-
Lyza Danger Gardner authored
* Add a wrapper element around the `Menu` component and apply styles to make sure it stretches/fills vertical space in parent * Add utility class for small icon styling Fixes #2302
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump puppeteer from 4.0.1 to 5.0.0
-
Robert Knight authored
Bump preact from 10.4.4 to 10.4.5
-
Robert Knight authored
Bump through2 from 4.0.1 to 4.0.2
-
Robert Knight authored
Bump @sentry/browser from 5.18.1 to 5.19.0
-
Robert Knight authored
Bump typescript from 3.9.5 to 3.9.6
-
Robert Knight authored
Enable type checking for src/sidebar/components, but exclude all the files that have errors
-
- 06 Jul, 2020 12 commits
-
-
Kyle Keating authored
-
Kyle Keating authored
-
dependabot-preview[bot] authored
Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) from 7.10.1 to 7.10.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.10.4/packages/babel-preset-react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.3.1 to 7.4.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.3.1...v7.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.10.3 to 7.10.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.10.4/packages/babel-core) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 4.0.1 to 5.0.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v4.0.1...v5.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.5 to 3.9.6. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [through2](https://github.com/rvagg/through2) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/rvagg/through2/releases) - [Commits](https://github.com/rvagg/through2/compare/v4.0.1...v4.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.4.4 to 10.4.5. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.4.4...10.4.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.18.1 to 5.19.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.18.1...5.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Send notifications to Slack about client deployment events
-
Robert Knight authored
-
- 04 Jul, 2020 2 commits
-
-
Robert Knight authored
These files typecheck without any changes required
-
Robert Knight authored
Enable typechecking for the src/sidebar/components directory, but add all files in that directory to an exclusion list of files which are not checked. As errors are resolved, they can be removed from that list. This gives us a "burndown" list that we can work our way through.
-
- 02 Jul, 2020 4 commits
-
-
Robert Knight authored
Enable typechecking for sidebar/store/modules
-
Lyza Gardner authored
Disable `_separate_replies` for annotation loading in sidebar (behind feature flag)
-
Robert Knight authored
Typecheck UI components in src/annotator/components
-
Robert Knight authored
- Add JSDoc for the `actionTypes` function. This uses an advanced TS feature called "mapped types" [1] to specify that the result is an object with the same keys as the input object, but where the values are strings rather than functions. Going forwards there are likely better ways to replace `actionTypes`. The original purpose was to make sure that the `type` field of each action object matches up with a key of the `updates` object. - Fix various existing JSDoc errors - Add imports for the existing `Group` and `Annotation` references - Add missing `group` property to `Annotation` type [1] https://www.typescriptlang.org/docs/handbook/advanced-types.html#mapped-types (See in particular the `in keyof T` mentions).
-
- 01 Jul, 2020 7 commits
-
-
Lyza Danger Gardner authored
When associated feature flag is set, `_separate_replies` will be set to `false` when loading annotations in the sidebar.
-
Robert Knight authored
This follows the same pattern that was introduced for `SvgIcon` in `propTypes` declarations are kept around for use at runtime by other code which is not yet typechecked. An issue that I encountered is that TS doesn't know about the custom HTML element types we use. For the moment I have ignored these with `@ts-ignore`, although I believe it should be possible to teach it.
-
Robert Knight authored
Typecheck SvgIcon
-
Robert Knight authored
- Remove a param comment that duplicates information in the type definition - Add a note about a defensive null-check
-
Lyza Gardner authored
Adjust the scale of layout spacing
-
Lyza Gardner authored
Refactor annotation publish control styling
-
Robert Knight authored
Typecheck `shared/components/svg-icon.js`. This enables edit-time rather than runtime detection of incorrect usage, as well as enabling UI component props to reference types (eg. API objects) defined elsewhere with JSDoc. Props are currently declared with both JSDoc and via `SvgIcon.propTypes`. The intent is that the JSDoc is the canonical definition, but `SvgIcon.propTypes` is still useful to catch incorrect usage from other parts of the code which are currently not typechecked.
-
- 30 Jun, 2020 3 commits
-
-
Robert Knight authored
Typecheck src/sidebar/services
-
Robert Knight authored
As suggested in PR feedback, this can help readability. We should do the same in parameter lists as well.
-
Robert Knight authored
Bump through2 from 3.0.1 to 4.0.1
-
- 29 Jun, 2020 2 commits
-
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.702.0 to 2.706.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.702.0...v2.706.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v4.0.0...v4.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-