- 22 Oct, 2015 1 commit
-
-
Sean Hammond authored
No longer used
-
- 21 Oct, 2015 5 commits
-
-
Sean Hammond authored
Rename permissions.public() -> permissions.shared() and permissions.isPublic() -> permissions.isShared(). This is more consistent with language used elsewhere in the code, now that we have groups.
-
Sean Hammond authored
Set the group and visibility of replies to that of their parents, when replies are first created. Also prevent the visibility setting of a reply from overwriting the cached-in-local-storage visibility level. This prevents the following problem: - I'm annotating publicly (my cached-in-local-storage visibility setting is public) - I reply to a private annotation - The visibility of my reply is set to that of its parent, private - This visibility is then cached in local storage - I make a new top-level annotation, and now it's defaulting to private instead of public, even though the user never did anything to change the visibility from public to private, it was done automatically because they replied to a private annotation. Obviously changing the mode from private to public when replying to a public annotation was also possible. This means that if the user _does_ change the visibility of a reply, we _don't_ cache that either: - I'm annotating publicly (my cached-in-local-storage visibility setting is public) - I reply to a public annotation - The visibility of my reply is set to that of its parent, public - This visibility is not cached in local storage because it's a reply (and the value cached in the local storage is already the same anyway) - I then deliberately change the visibility of my reply from public to private - Again this visibility is not cached in local storage because it's a reply - The next time I make a new top-level annotation, it will still be defaulting to public, will not have changed to private mode
-
Nick Stenning authored
Remove get_by_userid()
-
Nick Stenning authored
Extension build type indicator
-
Sean Hammond authored
Iterate over a copy of the open websockets list
-
- 20 Oct, 2015 4 commits
-
-
Nick Stenning authored
Extract sort dropdown into own component
-
Nick Stenning authored
Extension badge refactor
-
Robert Knight authored
Extract the sort dropdown into a reusable component and add tests. T-91
-
Robert Knight authored
Make BrowserAction actually stateless - its responsibility is just to map the logical H state of a tab (active/inactive/errored, annotation count) to the badge state. * Convert the per-tab state stored in TabState from a string into an object so that we can store additional state, starting with the badge count. * Move the function for fetching the badge's annotation count and updating the H tab state into TabState. This decouples the presentation of the badge from the logic of making network requests and updating the model.
-
- 19 Oct, 2015 8 commits
-
-
Nick Stenning authored
Update npm / python modules before running tests
-
Nick Stenning authored
Fix an issue where clicking the search icon would submit the form
-
Robert Knight authored
Make settings loader CSP-compatible
-
Nick Stenning authored
I forgot about CSP! We disallow inline scripts in the Chrome extension, so 18c47ba broke the extension. This commit replaces an inline script with some JSON data, parsed by the settings factory.
-
Robert Knight authored
Clicking the search icon should only focus the search field, not submit the search. This addresses the issue mentioned at https://github.com/hypothesis/h/pull/2622#issuecomment-148808509
-
Nick Stenning authored
New design for top bar
-
Nick Stenning authored
Add userid_domain config setting
-
Nick Stenning authored
Fix group link not being focused in dropdown menu if group hash IDs started with a number
-
- 16 Oct, 2015 17 commits
-
-
Robert Knight authored
The hash ID was not quoted when constructing the selector used to find the group's link field in order to focus it, resulting in an error depending on the chars in the hash ID.
-
Sean Hammond authored
Revert "Use "should" instead of "must" for search queries"
-
Sean Hammond authored
Add authors to RSS feed
-
Sean Hammond authored
Simplify streamer
-
Robert Knight authored
Override the browser default styling on the search input's width property so that its maximum width will be limited by the available space in the top bar when expanded. Previously it was inflexible due to the browser default styling with the group name being pushed off the left side of the top bar as a result. There is still an issue at the moment in Firefox where the share icon gets covered by the search bar when expanded. T-90
-
Robert Knight authored
When the top-bar is used in the stream, the content needs to be centered above the stream's contents. T-90
-
Robert Knight authored
* Add a couple of missing titles * Fix hover state for share icon when groups is disabled T-90
-
Robert Knight authored
The input field has no padding by default so that it does not take up space when collapsed. When expanded we need some padding between the icon and the input.
-
Robert Knight authored
53bd01169cd8eb00748f953a6b2488f09637b32c incorrectly changed the '.annotator-no-transition' selector which disables the animated width transitions on the sidebar during manual resizes to '.annotator-frame .annotator-no-transition' which meant that it did not take effect. T-90
-
Robert Knight authored
T-90
-
Robert Knight authored
* Make the spacing between the top bar icons consistent * Remove redundant CSS from top-bar.scss The CSS usage here is a little ugly because .top-bar__btn is used inside the <simple-search> directive but at least it is clear where the style comes from.
-
Robert Knight authored
This adds updated icons which were designed together and line up correctly.
-
Robert Knight authored
Support redirect-after-login
-
Robert Knight authored
Implement the design changes from https://trello.com/c/DZEDxU4C/90-top-bar-ui-updates - Move the 'My Annotations' item up and change the label to the account username - Swap Feedback and Help - Make the 'Sign out' link more subtle * BEM-ify the dropdown menu link CSS for consistency and to avoid specificity conflicts
-
Robert Knight authored
Following UX discussion: * Expand the search bar only on click rather than hover * Add missing title to search bar component
-
Robert Knight authored
* Adjust the styling of the icon so that the bottom of the 'chat heads' icon for groups is aligned vertically with the baseline of the group name label * Remove extra space between group name label and dropdown indicator arrow T-90
-
Sean Hammond authored
streamer: Don't silently stop processing on exceptions
-
- 15 Oct, 2015 5 commits
-
-
Robert Knight authored
Increase top bar height to 40px to match the designs. A visual side effect is that the dropdown menus now overlap the top bar and clearly appear on top of it rather than just below.
-
Robert Knight authored
Position the arrow at the top of the groups list dropdown menu so that it appears beneath the dropdown indicator in the top-bar. This is done by hiding the dropdown menu's "built in" arrow created via CSS :before and :after pseudo-elements and introducing a separate element which uses the same technique with borders to create the dropdown arrow. The use of a separate element for the arrow allows it to be aligned with the right edge of the dropdown menu's parent element (in this case, the group name in the top bar) rather than the dropdown menu's content.
-
Robert Knight authored
* Set the inner container in the top bar to the full height of the top bar. This corrects the vertical alignment of the toolbar icons. * Remove the extraneous 'content' class from the top bar * Remove unused selectors for button styling T-90
-
Robert Knight authored
When the new top-bar design is enabled, collapse the search input unless the field is hovered, focused or there is an active search query. In the legacy top-bar design, the search field remains expanded all the time T-90
-
Robert Knight authored
Explicit settings for websocket
-