1. 14 Oct, 2015 1 commit
  2. 13 Oct, 2015 13 commits
  3. 12 Oct, 2015 3 commits
  4. 09 Oct, 2015 11 commits
  5. 08 Oct, 2015 5 commits
  6. 07 Oct, 2015 5 commits
    • Robert Knight's avatar
      Implement the UI for leaving a group · 15b2422a
      Robert Knight authored
      Add a new cancel/leave icon next to private groups
      in the groups list and invoke groups.leave() when clicked.
      
      Leaving a group invokes the as-yet-unimplemented
      'POST /groups/<id>/leave' endpoint on the server.
      
      T-88
      15b2422a
    • Nick Stenning's avatar
      Merge pull request #2596 from robertknight/icon_font_fix_2 · 053ec08a
      Nick Stenning authored
      Inline the H icon font
      053ec08a
    • Robert Knight's avatar
      Merge pull request #2594 from hypothesis/fix-groups-race · f0312ef8
      Robert Knight authored
      Fix race for session data on startup
      f0312ef8
    • Robert Knight's avatar
      Inline the H icon font · c3960b8e
      Robert Knight authored
      The previous fix to use an absolute URL to the icon
      font did not work in the Chrome extension because
      the base path for assets was different.
      
      The proper solution here will involve refactoring
      the CSS build pipeline and possibly automatically
      inlining font URLs in the process. I did not just
      add a preprocessor to inline all URLs because
      that would also have affected fonts in katex.min.css
      and added significantly to the size of the CSS bundle.
      
      This commit reverts back to the previous solution of
      inlining just the icon font.
      
      See #2571
      c3960b8e
    • Nick Stenning's avatar
      Fix race for session data on startup · 804def7d
      Nick Stenning authored
      Several parts of the application require access to the session data
      fetched from the server when rendering. On first page load we don't have
      this data (something we can fix in the future by inlining the data with
      the viewer HTML) and this resulted in a race between the session data
      load triggered by `checkAuthentication` (in config/identity.js) and the
      query sent to the server by `WidgetController`, which needs to know the
      current focused group id.
      
      Fix this by ensuring that the first load of session data is complete
      before switching views -- achieved by adding an item to the list of
      dependencies passed to `$routeProvider`.
      
      This works, but results in multiple requests for session data in quick
      succession, because `checkAuthentication` runs while the view is
      loading. To resolve this problem, we add a straightforward TTL check to
      the `session.load()` method, and only make a new request if the data is
      more than 5m old.
      
      Session data will be overwritten as normal whenever session mutating
      methods (`session.login()`, `session.logout()`) etc. are called.
      
      Fixes #2590.
      804def7d
  7. 06 Oct, 2015 2 commits