1. 22 Sep, 2017 1 commit
  2. 21 Sep, 2017 3 commits
    • Robert Knight's avatar
      Remove iframe size check · d8eedc34
      Robert Knight authored
      Since we now only enable annotation of iframes that are explicitly opted
      in by the containing page, we can avoid checking the size of the iframe
      as well. That check was originally added to filter out ads and hidden
      iframes.
      
      This resolves an issue with Epub.js where an iframe initially has zero
      width. This is because book content is laid out into a variable number
      of fixed-width columns and the iframe's width is set to the total width
      of all columns. Until the content is loaded, the number of columns and
      hence the width, is zero.
      d8eedc34
    • Sean Hammond's avatar
      Merge pull request #549 from hypothesis/remove-window-annotator-export · 0c73c43e
      Sean Hammond authored
      Stop exporting the main annotation layer object as `window.annotator`
      0c73c43e
    • Robert Knight's avatar
      Stop exporting the main annotation layer object as `window.annotator` · 0033f774
      Robert Knight authored
      The main application object in the code which runs in the host page was
      made visible to other code on the page as `window.annotator`.
      
      This export existed for legacy reasons (the client's Annotator.js
      heritage), is not part of the public API of the client and we do not
      make any effort to avoid breaking changes to it between releases.
      Removing this export should prevent third parties writing code which
      depends on its interface.
      0033f774
  3. 20 Sep, 2017 4 commits
  4. 18 Sep, 2017 5 commits
  5. 15 Sep, 2017 4 commits
  6. 14 Sep, 2017 4 commits
  7. 11 Sep, 2017 12 commits
  8. 08 Sep, 2017 2 commits
    • Robert Knight's avatar
      Fix OAuth popup being blocked by pop-up blocker in Firefox and IE · 7be7735a
      Robert Knight authored
      When the user clicked the "Log in" link, the URL of the
      "oauth.authorize" endpoint was fetched via an async Promise-returning
      method before the `window.open` call was made. This meant that the
      `window.open` call did not happen in the turn of the event loop that was
      triggered by the user action and so Firefox & IE's popup blockers deemed
      the call to have happened outside the context of a user gesture and
      prevented the window being opened.
      
      Chrome, Safari & Edge have different heuristics and did not block the
      popup before.
      
      Fix the issue by opening the window directly when the user clicks on the
      "Log in" button, at a dummy URL ("about:blank"), and then changing the
      window's location once the authorization endpoint URL has been fetched.
      
      Fixes #534
      7be7735a
    • Robert Knight's avatar
      Remove unused refresh timer variable · 0adad3b1
      Robert Knight authored
      This was missed during 28bdb52f
      0adad3b1
  9. 07 Sep, 2017 3 commits
  10. 06 Sep, 2017 2 commits