1. 21 Jul, 2017 1 commit
  2. 11 Jul, 2017 7 commits
  3. 10 Jul, 2017 2 commits
    • Sean Roberts's avatar
      Merge pull request #489 from hypothesis/destroy-frame-mutation · 85225124
      Sean Roberts authored
      Avoid mutating frames array in DESTROY_FRAME action.
      85225124
    • Robert Knight's avatar
      Fix adder position when document or body position is offset. · efbdc813
      Robert Knight authored
      Fix positioning of the adder when the document or body elements are
      positioned and offset relative to their default position.
      
      There were two problems:
      
       1. When converting from viewport to "document" coordinates, code in
          `adder.js` and `range-util.js` failed to account for the document
          element's position being offset from the default (0, 0) location.
       2. When setting the adder's top/left coords, `Adder#showAt`
          did not take into account the offset of the body element from the
          document.
      
      This commit fixes the issue by:
      
       1. Using viewport coordinates as far as possible in the range-util and
          Adder functions to reduce the need for converting coordinates.
      
       2. Calculating the position of the adder by comparing the target
          viewport coordinates for the adder and the viewport coordinates of
          the adder's nearest positioned ancestor.
      
      Fixes #487
      efbdc813
  4. 07 Jul, 2017 1 commit
  5. 06 Jul, 2017 6 commits
  6. 05 Jul, 2017 11 commits
  7. 04 Jul, 2017 3 commits
  8. 03 Jul, 2017 1 commit
    • Sean Hammond's avatar
      Fix view switcher flash on iOS · 450beedd
      Sean Hammond authored
      The view switcher tabs at the top of the sidebar would flash grey for a
      moment after you clicked one. This removes the flash.
      
      This webkit "tap highlight" is actually an iOS Safari usability feature,
      it indicates to the user that their tap is being successfully recognized, and
      indicates which element they're tapping on. But I don't think it looks
      good with these tabs of ours, and it seems to interact badly with the
      background colour animated transition we're using (it seems to do the
      animated transition first and _then_ flash the tap highlight colour for
      a second).
      
      We're providing this indication by changing the colour of the tab
      anyway, so disable it.
      450beedd
  9. 30 Jun, 2017 2 commits
  10. 29 Jun, 2017 6 commits