1. 28 Jun, 2016 1 commit
    • Robert Knight's avatar
      Match annotations by tags and ID in excludeAnnotations() · de6fa295
      Robert Knight authored
      After creating an annotation, we remove the pre-created annotation from
      the Redux store and replace it with the saved version from the server.
      
      In order to determine which pre-created annotation to remove when adding
      the version from the server, we need to match on local tag, since the
      version from the server has no ID - but it does have a local tag since
      that is copied across from the pre-to-post created version.
      de6fa295
  2. 24 Jun, 2016 1 commit
  3. 23 Jun, 2016 3 commits
    • Sean Hammond's avatar
      Merge pull request #3519 from hypothesis/request-scoped-session · 979b83c4
      Sean Hammond authored
      Use request-scoped rather than thread-local session
      979b83c4
    • Robert Knight's avatar
      Merge pull request #3531 from hypothesis/fix-missing-pdf-highlights · 3242665f
      Robert Knight authored
      Fix missing PDF highlights
      3242665f
    • Nick Stenning's avatar
      Fix missing PDF highlights · 8f4cc121
      Nick Stenning authored
      fda63b4 unfortunately broke highlighting in PDFs, because the PDF
      anchoring code first finds the text in the document, and then uses a
      TextPositionSelector and the HTML anchoring code to select a range in
      the rendered page for highlighting.
      
      This commit fixes that issue by moving the TextQuoteSelector check up a
      level into `Guest#anchor`.
      
      I've added two tests for this in `guest-test.coffee` -- one tests that
      annotations where the target contains no TextQuoteSelector are marked as
      orphans, and the second tests that the low-level anchoring code is never
      called in this case.
      
      I have also removed the integration test, on the basis that I don't
      think integration testing failure cases is a good habit to get into.
      
      Fixes #3530.
      8f4cc121
  4. 22 Jun, 2016 3 commits
  5. 21 Jun, 2016 7 commits
  6. 20 Jun, 2016 9 commits
  7. 17 Jun, 2016 9 commits
  8. 16 Jun, 2016 6 commits
  9. 15 Jun, 2016 1 commit