- 29 Sep, 2015 2 commits
-
-
Robert Knight authored
The spacing was lost when the cancel button was moved into the <publish-annotation-btn> directive. Card 89
-
Robert Knight authored
* Use cancel button with a thin circle outline * Change normal and hover colors to light/dark grey as per discussion on the card. Card 89
-
- 28 Sep, 2015 3 commits
-
-
Robert Knight authored
Add a cancel button with a thin circle outline which matches the design. Card 89
-
Robert Knight authored
Card 89
-
Robert Knight authored
This text has been obsoleted by the new 'Post to XXX' design which makes it clearer who new annotations will be visible to. Card 89
-
- 26 Sep, 2015 18 commits
-
-
Robert Knight authored
Card 89
-
Robert Knight authored
Instead of passing a full object of attributes to util.createDirective() at the start of each test, render a default instance in beforeEach() and then just relink the element with the changes for a specific test. Card 89
-
Robert Knight authored
Card 89
-
Robert Knight authored
Card 89
-
Robert Knight authored
Card 89
-
Robert Knight authored
When false, both the dropdown menu and the post button are disabled. Card 89
-
Robert Knight authored
The <privacy> drop-down has been replaced by the new combined Post / privacy button. Card 89
-
Robert Knight authored
Card 89
-
Robert Knight authored
Re-implement the behavior where new annotations use the last-used privacy setting by default. This was previously implemented in privacy.js and the logic now lives in the replacement component, publish-annotation-btn.js. However, the defaults really shouldn't be set in the view but earlier when the new annotation is created. Card 89
-
Robert Knight authored
The newer version of Angular UI bootstrap has an optional keyboard-nav directive to make dropdowns keyboard accessible. Card 89
-
Robert Knight authored
Using a <button> gives us keyboard accessibility and focus. The downside is that additional styling is needed to suppress default styling from the UA. Card 89
-
Robert Knight authored
This is a more descriptive name explaining what the component is for. Card 89
-
Robert Knight authored
* Move the annotation privacy label below the button. The label's height may vary depending on the selected option, so moving it below the button avoids changing the button's position when a different option is selected from the dropdown. * Remove the previous separate privacy dropdown and replace with the combined button. * Use flexbox to simplify layout of the annotation form actions Card 89
-
Robert Knight authored
This directive provides a button to publish an annotation plus a dropdown-menu for changing its privacy settings. Card 89
-
Robert Knight authored
h/static/scripts/vendor/angular-bootstrap.js contains a legacy version of the dropdown component ui-bootstrap contains the current version with additional features including the ability to open and close the dropdown via an 'is-open' attribute, keyboard navigation support and the ability to use it via attribute directives. This build has been lightly edited for Angular 1.2.x compatibility (the original build requires a couple of features from Angular 1.3) Card 89
-
Robert Knight authored
Due to the existence of a 'p + p' selector in app.css, the <p> element containing the 'This annotation is visible only to you' label was displayed at a different vertical position to the alternative labels. Use ng-if rather than ng-show to remove the non-visible labels so that the rendered <p> is always the first <p> child of its parent and therefore always rendered at the same position.
-
Robert Knight authored
The annotation action links were too small to be easily legible, as was the 'This annotation will be visible to ...' label. This sets the size of 'small' text to $body1-font-size which is the smallest legible size for text in the app.
-
Robert Knight authored
<primary-action-btn> is the purely visual component which provides a button with a dropdown arrow menu that will open an associated dropdown menu. An additional component or controller will then wrap this and provide the actual Save functionality. Card 89
-
- 25 Sep, 2015 9 commits
-
-
Nick Stenning authored
(see 9d57500)
-
Nick Stenning authored
(Because compiling assets is something we do in production.)
-
Sean Hammond authored
Fix comments (AKA "page notes") with search_normalized
-
Nick Stenning authored
Previously, an annotation with a selectorless target (such as a comment or "page note") would be marked as an orphan. This commit adjusts the orphan detection code so that an annotation is marked as an orphan only if both of the following conditions are met: - it has at least one target with selectors (an "anchorable target") - none of the anchorable targets have successfully anchored
-
Nick Stenning authored
In order for comments (AKA "page notes") to be discoverable with the search logic implemented in #2413 (cc4ca35), they need to have at least one target with a source field. Previously a comment was defined as an annotation - with a `uri` - without any targets - without any references (no targets but with references == a reply) Now comments have a single target with a single field, `source`. This finally puts us in a position where we can consider deprecating the `uri` field.
-
Nick Stenning authored
If one of these asserts fails, then this test will timeout (taking 2 seconds to do so). By using a small helper (`timeoutPromise`) to implement the "next tick" functionality that was previously achieved with `setTimeout`, this is improved: we return a promise from the test function and a failure will be reported immediately. See https://mochajs.org/#working-with-promises for more on returning promises from mocha test functions.
-
Nick Stenning authored
It's not at all clear from the code that the singular "selector" is in fact an array of selectors referring to a single target. Add a few comments to help understanding this until we can sort out a better refactoring/naming.
-
Nick Stenning authored
The last thing that used this was removed in 7829cc1.
-
Nick Stenning authored
Change $anchored -> $orphan
-
- 24 Sep, 2015 5 commits
-
-
Sean Hammond authored
-
Sean Hammond authored
Instead of setting $anchored=true on anchored annotations, set $orphan=true on orphaned (i.e. unanchored) ones as we used to do. Orphaned annotations are the exception: we don't show them, or if show_unanchored_annotations is one then we show them with a warning. It's simpler and less buggy to add $orphan=true onto the exceptional annotations than to try to add $anchored=true onto all of the unexceptional ones. Fixes #2525. Fixes #2541.
-
Nick Stenning authored
Fix document title and domain for local file PDF annotations
-
Sean Hammond authored
This fixes two issues on the annotation cards for some annotations: 1. If the annotated document has a non-http(s) URI (e.g. a local file:// URI) then don't hyperlink the document's title to that URI 2. If the annotated document has no .domain value or its domain is the same as its title then don't display anything, instead of displaying a pair of emtpy braces (). To fix this move the logic for formatting an annotation's document's title and domain into AngularJS filters where it can be tested, instead of in the template.
-
Nick Stenning authored
Use autoprefixer to add vendor prefixes to CSS
-
- 23 Sep, 2015 3 commits
-
-
Robert Knight authored
Translate annotation mapper
-
Nick Stenning authored
Hide unanchored warnings when not sidebar
-
Sean Hammond authored
Don't show the "We can't find the exact position of this annotation" warnings on unanchored annotations when on the stream or individual annotation pages - only show them in the sidebar.
-