- 12 Feb, 2018 3 commits
-
-
Robert Knight authored
Fix a test failure due to a subtle issue with the interaction between the `$q` service, `AnnotationController#delete` and `$timeout.flush` in tests. Instantiating the rejected promise _before_ calling `$timeout.flush` resulted in Angular's unhandled promise checking code being triggered in the test.
-
Robert Knight authored
Fix occurrences of a "multilink" [1] error during test for the annotation save button. Replace calls to the link function with direct assignments to controller properties. [1] https://code.angularjs.org/1.6.9/docs/error/$compile/multilink
-
Robert Knight authored
The main change that affects us is that component inputs/bindings are no longer available as controller properties in the constructor by default. Instead this logic should go in a controller's `$onInit` method. In this commit use the `$compileProvider.preAssignBindingsEnabled` compatibility helper which preserves the Angular <= 1.5 behavior. This is being removed in Angular 1.7.
-
- 09 Feb, 2018 1 commit
-
-
Sheetal Umesh Kumar authored
Refactor export of bound selectors from Redux store
-
- 06 Feb, 2018 1 commit
-
-
Robert Knight authored
Group the selectors in each Redux module together in a `selectors` object so they can be re-exported as methods on the Redux store without having to list each of them manually. This also just makes it easier to visually see which exported functions from a Redux module are selectors.
-
- 30 Jan, 2018 4 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sean Hammond authored
Hide the direct-link CTA for third party accounts
-
Robert Knight authored
The CTA message shown when an anonymous user visits a direct link contains links to the Hypothesis site and makes other assumptions, such as the user being able to create accounts and those accounts being free, which may not be applicable on sites that use third party accounts. For now, just hide this CTA if the page uses third party accounts. Fixes #656 Fixes #657
-
- 29 Jan, 2018 1 commit
-
-
Robert Knight authored
Add script to initiate a client release
-
- 25 Jan, 2018 4 commits
-
-
Robert Knight authored
Add a script to handle creating a new client release using yarn, ensuring that the Git tag is signed. Unfortunately yarn's default is for this setting to be turned off. Also unlike `npm version`, `yarn version` does not support automatically incrementing the package version.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fix login flow triggering popup blocker in Firefox and IE
-
- 24 Jan, 2018 2 commits
-
-
Robert Knight authored
Use the verb form for correctness in context and consistency with text on the h web pages.
-
Robert Knight authored
- Use the term "auth" for consistency with the `authorize` method and use the verb "open" to clarify that the popup window is being both created and shown. - Clarify the relation of the `$window` parameter to the returned window.
-
- 22 Jan, 2018 1 commit
-
-
Robert Knight authored
hypothesis/client#603 broke the login popup window in Firefox and IE because the call to `window.open` no longer happens in the same turn of the event loop as the user's click on the "Login" link. It is therefore no longer considered in FF to have happened "in response to a user gesture". This PR fixes the issue by separating creation and use of the popup window into separate functions and moving creation to happen earlier, in the same event loop turn as the "Login" button click. Fixes #534
-
- 19 Jan, 2018 1 commit
-
-
katelyn authored
Now there are two separate links for requesting an invite to our public Slack workspace (slack.hypothes.is) and accessing the workspace once you already have an account (hypothesis-open.slack.com)
-
- 10 Jan, 2018 2 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
- 09 Jan, 2018 1 commit
-
-
Lyza Gardner authored
Allow whitelisted URL params in YouTube embeds add support for `t`, `start` and `end` query params for embedded YouTube videos.
-
- 19 Dec, 2017 11 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Update reference to annotator CSS bundle.
-
Robert Knight authored
`adder.js` contains a reference to the main CSS bundle generated from src/styles/annotator which was not updated when the CSS bundle's name was changed in f0b61e6a
-
Sheetal Umesh Kumar authored
Rename JS bundles to match corresponding source directory
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Rename the "injector" and "app" bundles to "annotator" and "sidebar" respectively to match the source directory which produces those bundles.
-
Sheetal Umesh Kumar authored
Rename entry point for annotator CSS bundle
-
Sheetal Umesh Kumar authored
Restructure sidebar styles in source tree
-
Sheetal Umesh Kumar authored
Rename entry points for annotator and sidebar bundles to 'index.js'
-
- 12 Dec, 2017 2 commits
-
-
Robert Knight authored
Update the docs for config options available to third party publishers.
-
Sheetal Umesh Kumar authored
-
- 11 Dec, 2017 6 commits
-
-
Robert Knight authored
Rename the entry point for the annotator CSS bundle so that it matches the name of the source directory from which the bundle is compiled and also the name of the corresponding JS bundle once that is renamed by hypothesis/client#633
-
Robert Knight authored
- Move the sidebar-specific styles into `styles/sidebar` and the component-specific styles into `styles/sidebar/components`. This mirrors the structure of the JS code in `src/`. - Rename the entry point for the sidebar's style bundle from "app.scss" to "sidebar.scss" to make it more obvious what is in the generated "sidebar.css" bundle. This move highlights some inappropriate dependencies between style modules and an unclearly structured assortment of "stuff" shared by both annotator and sidebar bundles in shared files in `src/styles`. There is probably a fair amount of unused code in there as well. Cleaning that up will happen in separate commits.
-
Robert Knight authored
Rename the entry points to the more conventional 'index.js' for the benefit of new visitors to the codebase and also for consistency across the different bundles that make up the client.
-
Robert Knight authored
-
Robert Knight authored
-
Sean Hammond authored
Remove create account banner
-