- 19 Dec, 2012 12 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
Chrome is bugging about it and won't submit the form on the first 'enter' press.
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
In the editor, should show detail view of the new annotation, while, in the detail viewer, should stay put.
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
... to arrive at parity with h/develop.
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
- 18 Dec, 2012 14 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
I find this easier to read. "Unless there's a detail being shown, calculate the dynamic bucket, but if there's no heatmap, then show nothing."
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
When Angular compiles a directive the transclude linking function passed to the compiler is not passed on to child node compilations unless the current node performs no linking. When the current node does have a linking function it's expected that the node requested transclusion and the child transclusion function is passed in place of the one that the compile service was called with. During linking, however, any transclude function passed to compile is bound and passed to children so that the the $transclude service can be provided to controllers. Unfortunately, ngRepeat uses the transclude linking function available to directives and not the tranclude service available to controllers so elements with link-performing directives on the path from the recursive element to an ngRepeat directive will break transclusion since ngRepeat will receive a null transclusion function. When it links its children, the null transclusion function is made available as the $transclude service rather than the bound transclusion function which ngRepeat was, itself, linked with. All of this is a bit orthogonal to the change, but the change is made because I think it makes more sense for what I imagine could be common usage of the recursive directive.
-
Randall Leeds authored
-
Randall Leeds authored
Implement deleteAnnotation in the host to remove temporary highlights after annotations get their ids assigned.
-
Randall Leeds authored
Eventually, I'll make it switch from editor to detail when you save an annotation, but I'm having some weird issues with racing scope values that I don't understand.
-
- 17 Dec, 2012 7 commits
-
-
Randall Leeds authored
Conflicts: h/css/app.scss
-
Randall Leeds authored
... just hide it. This avoids a flash of the detail listing going away before the panel slides away and also makes reloading the same panel instantaneous.
-
Randall Leeds authored
This setting can mess with the dirty caches of Chrome, and probably other browsers, forcing compositing and forcing repaints for pixels which would otherwise just be scrolled. It also plays poorly with the CSS3 Transform being used for the sliding panels, making the background "snap" when the transform finishes.
-
Randall Leeds authored
-
Jehan Tremback authored
-
-
Randall Leeds authored
This serves a few purposes: - It unwinds the stack during recursive linking so that the directive will work with structures of arbitrary depth. - It optimizes repaints by making clone attachments in bulk during animation frames. - It allows the sliding panel to immediately begin animating rather than delaying until linking is finished. This makes for a more responsive feel when transitioning to the detail view.
-
- 15 Dec, 2012 3 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
Before, we were transcluding only the contents. This seemed to do nasty things with Angular's scoping. Could be related to angular/angular.js#1313
-
- 14 Dec, 2012 4 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
Use the threading instead.
-
Randall Leeds authored
-
Randall Leeds authored
Also, rework the hash nonsense to use annotation ids and assign temporary ids for the host and provider to share until saving to the server.
-