Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 18 Feb, 2019 1 commit
    • Robert Knight's avatar
      Avoid using build executor while waiting for deployment confirmation · ee9ecb42
      Robert Knight authored 
      The Jenkinsfile previously has this structure:

```
node {
  // Do checkout, run tests etc.
  ...
  stage('Deploy to prod') {
    input(message: "Deploy to prod")
  }
}
```

While any steps inside the `node` block are running or waiting, the pipeline
will consume a build executor slot. If several client builds were waiting for
manual input, this could prevent other Jenkins jobs from running.

This commit restructures the Jenkinsfile like so:

```
node {
  // Do checkout, run tests etc.
}

stage('Deploy to prod') {
  input(message: 'Deploy to prod?')
  node {
    // Do the deployment
  }
}

As a result, a client build waiting to be deployed to production will no longer
consume a build executor slot.

See also the "7. Don't: Use input within a node" tip in [1]

Fixes #955

[1] https://www.cloudbees.com/blog/top-10-best-practices-jenkins-pipeline-plugin
      ee9ecb42
  3. 14 Feb, 2019 2 commits
  5. 13 Feb, 2019 2 commits
  7. 12 Feb, 2019 2 commits
  9. 11 Feb, 2019 4 commits
  11. 07 Feb, 2019 10 commits
  13. 06 Feb, 2019 11 commits
  15. 05 Feb, 2019 8 commits