- 01 Apr, 2020 3 commits
-
-
Robert Knight authored
This adds basic runtime verification that mocked components are called with types that are compatible with what the real component expects. This turned up one existing issue with use of `MenuSection` by `UserMenu`, where conditional rendering would cause the prop type check to fail.
-
Robert Knight authored
For consistency with other tests, use `mockImportedComponents` so that an issue with an imported component doesn't cause a cascade of failures in the unit tests for these components.
-
Robert Knight authored
Only create one highlight element for adjacent text nodes
-
- 31 Mar, 2020 4 commits
-
-
Robert Knight authored
Replace angular-mocks in service tests
-
Robert Knight authored
Bump @sentry/browser from 5.15.0 to 5.15.4
-
Robert Knight authored
-
Robert Knight authored
-
- 30 Mar, 2020 19 commits
-
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.15.0 to 5.15.4. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.15.0...5.15.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump autoprefixer from 9.7.4 to 9.7.5
-
dependabot-preview[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.7.4 to 9.7.5. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/9.7.4...9.7.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump browserify from 16.5.0 to 16.5.1
-
dependabot-preview[bot] authored
Bumps [browserify](https://github.com/browserify/browserify) from 16.5.0 to 16.5.1. - [Release notes](https://github.com/browserify/browserify/releases) - [Changelog](https://github.com/browserify/browserify/blob/master/changelog.markdown) - [Commits](https://github.com/browserify/browserify/compare/v16.5.0...v16.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump dom-seek from 4.0.3 to 5.0.1
-
dependabot-preview[bot] authored
Bumps [dom-seek](https://github.com/tilgovi/dom-seek) from 4.0.3 to 5.0.1. - [Release notes](https://github.com/tilgovi/dom-seek/releases) - [Commits](https://github.com/tilgovi/dom-seek/compare/v4.0.3...v5.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
When highlighting a run of adjacent text nodes, wrap the group of adjacent text nodes in a single `<hypothesis-highlight>` element rather than wrapping each text node separately. Adjacent text nodes may be created if: - A sub-range of the text is highlighted by Hypothesis, and the highlight is later removed, for example when switching groups. - The text nodes were generated programatically by JavaScript rather than by the browser's HTML parser For screen reader users, this reduces the number of "annotation start"/"annotation end" comments they will hear in this scenario. It is also likely to benefit other code which interacts with highlighted text.
-
Robert Knight authored
As part of the migration away from Angular, replace the use of angular-mocks for constructing service instances in tests. - For tests that only have one or two dependencies, call the service constructor directly - For tests that have many dependencies, enough that the order could be easily mixed up if calling the constructor directly, re-use the `Injector` class which is used to wire up services in the real application Several of these tests relied on Angular's built-in `$rootScope` service. Use of this should go away entirely soon, but for this commit, just replace it with a minimal mock - either an object with stubs or an `EventEmitter`.
-
Robert Knight authored
Reformat with Prettier v2
-
Robert Knight authored
Even after adjusting the configuration to match Prettier 1.x output as closely as possible, some breaking changes did require running `make format`.
-
Robert Knight authored
Update the configuration so that it matches our other repos and is as close as possible with Prettier v2.x to Prettier v1.x output.
-
Kyle Keating authored
Add translation map for specific host-config values
-
Kyle Keating authored
add `type-coercion.js` util with 4 methods. These are used on incoming the host-config values `openSidebar` and `requestConfigFromFrame` which may have an incompatible type upstream (via3) from what the client expects. - toInteger - toObject - toString - toBoolean These methods coerces specific values into types so that downstream (client) methods can make assumptions. This is part of the prep work to support via3 which will eventually only export strings values in the config.
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 17.1.1 to 17.1.4. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v17.1.1...v17.1.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 2.5.1 to 3.0.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.643.0 to 2.648.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.643.0...v2.648.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 1.19.1 to 2.0.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/1.19.1...2.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/preset-react](https://github.com/babel/babel) from 7.9.1 to 7.9.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.1...v7.9.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 27 Mar, 2020 9 commits
-
-
Robert Knight authored
Revert mocha to v7.0.1
-
Robert Knight authored
In mocha >= 7.1.0, exceptions thrown in test hooks (eg. a `beforeEach` hook) cause the tests to hang without printing any useful exception details. From my notes in a Slack investion: > The karma-mocha package is responsible for running mocha by calling > mocha.setup() before the test modules are evaluated and then mocha.run() > after they are evaluated to actually run the tests, as well as listening > for test events from Mocha’s “runner” and reporting them back to Karma. > When the beforeEach hook fails, the runner emits a “fail” event which > karma-mocha receives. karma-mocha then attempts to emit a “test end” > event and that ends up triggering an exception in a call to > test.retriedTest() in code which was added in > https://github.com/mochajs/mocha/pull/4181/files. Until this issue is resolved, pin mocha to a version that doesn't trigger this problem.
-
Lyza Gardner authored
Replace `annotation-thread` with preact `Thread` component
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Adjust CSS not contained within `Thread` to account for annotations displayed within nested threads.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
Exclude src/test-util from code coverage metrics
-
Robert Knight authored
Our current policy is not to include test-only code in coverage metrics.
-
- 26 Mar, 2020 2 commits
-
-
Kyle Keating authored
Add preStart method to cross-origin-rcp module
-
Kyle Keating authored
When called, allows any incoming rpc request to wait in a queue and be proceeded a short time later when the actual start() method is called. This prevents potential timeouts from incoming RPC requests from LMS (or similar) that arrive after we tipped off the parent frame with a fetchConfig outgoing request but before startServer() is called. - Rename start() to startServer() - Use newer module export standard that matches the rest of the app
-
- 24 Mar, 2020 3 commits
-
-
Robert Knight authored
Remove $location service and annotation subcomponents from sidebar entry module
-
Lyza Gardner authored
Remove unused `permissions` service
-
Robert Knight authored
After `Annotation` was converted to Preact, the subcomponents no longer need to be wrapped and exposed to Angular.
-