1. 22 Oct, 2019 3 commits
    • Robert Knight's avatar
      Fix anchoring failing when last text on a PDF page is selected · f4af44b5
      Robert Knight authored
      Change PDF anchoring to use the new text position => Range
      implementation from the `src/annotator/anchoring/text-position` module
      which fixes an issue when the last text in a PDF page is selected.
      
      Fixes #1329
      f4af44b5
    • Robert Knight's avatar
      Add a new implementation of text position => Range conversion · 07773973
      Robert Knight authored
      Add a new implementation of conversion from text positions (that is,
      offsets within an element's `textContent`) to DOM `Range`s along with
      test cases.
      
      This addresses an issue with the existing implementation of `toRange` in
      the `dom-anchor-text-position` package where conversion fails when the
      text position includes the end of the element's text.
      
      Even if/when the issue is addressed upstream, I think it would be useful
      to retain these test cases to guard against future regressions.
      
      See #1329
      07773973
    • Robert Knight's avatar
      Add a failing test case for annotation matching last text on page · 623a359b
      Robert Knight authored
      This currently fails to a bug on `dom-anchor-text-position`'s `toRange`
      implementation.
      
      See #1329
      623a359b
  2. 21 Oct, 2019 14 commits
  3. 17 Oct, 2019 13 commits
  4. 15 Oct, 2019 10 commits