- 18 Apr, 2019 1 commit
-
-
Robert Knight authored
dom-anchor-fragment is shipped as a UMD module which causes problems on pages that declare a global function called `define` (see #479). While we could fix the module, fragment anchoring is not very useful at the moment. The client primarily anchors to the quote and uses other anchors only as an optimization. The Wikipedia baseline tests changed in this PR show how little value a fragment has on real websites. Therefore, just remove support for generating and using fragment selectors. This change should not cause anchoring regressions, as anchoring would only have succeeded previously if the quote selector matched. Now it will just fall through to anchoring using the range, position or quote selectors instead. Fixes #479
-
- 17 Apr, 2019 2 commits
-
-
Hannah Stepanek authored
Make group selectors more efficient
-
Robert Knight authored
Ensure that selectors for getting the "My groups", "Currently viewing groups" and "Featured groups" lists only recompute when the groups state changes. Previously they would have recomputed when _any_ part of the state changed. More generally, we should be using `createSelector` rather than `memoize` whenever we have a place in the app that needs to extract a subset of data from some larger structure and derive some data from that.
-
- 15 Apr, 2019 10 commits
-
-
Robert Knight authored
Bump @octokit/rest from 16.23.2 to 16.24.1
-
Robert Knight authored
Bump mocha from 6.1.2 to 6.1.3
-
Robert Knight authored
Bump prettier from 1.16.4 to 1.17.0
-
Robert Knight authored
Bump jquery from 3.3.1 to 3.4.0
-
Robert Knight authored
Bump enzyme-adapter-preact-pure from 1.10.4 to 1.12.0
-
dependabot[bot] authored
Bumps [enzyme-adapter-preact-pure](https://github.com/preactjs/enzyme-adapter-preact-pure) from 1.10.4 to 1.12.0. - [Release notes](https://github.com/preactjs/enzyme-adapter-preact-pure/releases) - [Changelog](https://github.com/preactjs/enzyme-adapter-preact-pure/blob/master/CHANGELOG.md) - [Commits](https://github.com/preactjs/enzyme-adapter-preact-pure/compare/v1.10.4...v1.12.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
dependabot[bot] authored
Bumps [jquery](https://github.com/jquery/jquery) from 3.3.1 to 3.4.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.3.1...3.4.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
dependabot[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.23.2 to 16.24.1. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v16.23.2...v16.24.1) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 1.16.4 to 1.17.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/1.16.4...1.17.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 6.1.2 to 6.1.3. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v6.1.2...v6.1.3) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
- 11 Apr, 2019 5 commits
-
-
Robert Knight authored
Fix npm dependencies make target not re-installing if yarn lockfile changed
-
Robert Knight authored
The make target used to ensure that npm dependencies are installed when they change depended on `yarn.lock` but didn't actually run `yarn install` if only that file, and not package.json, changed. The target relied on a tool called check-dependencies which pre-dates yarn. `yarn install` is fast if nothing changed, so just run it unconditionally.
-
Hannah Stepanek authored
Open the sidebar when direct-linked group
-
Hannah Stepanek authored
-
Robert Knight authored
Convert '<group-list-section>' to React
-
- 10 Apr, 2019 11 commits
-
-
Hannah Stepanek authored
Add annotations:group:GROUP_ID fragment url
-
Hannah Stepanek authored
- Add an api call to get the linked to group - Add the linked to group to the featuredGroups list. - Pass the directLinkedGroup into the filterGroups function. - Take into account the directLinkedGroup when deciding whether to filter out the "Public" group or not. - If there is a directLinkedGroup focus it.
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Robert Knight authored
- Rename `sectionGroups` to the slightly more obvious name `groups` - Add a comment
-
Robert Knight authored
These components are no longer within an Angular component but are used by GroupSection instead.
-
Robert Knight authored
-
Robert Knight authored
Fix feature flag race condition
-
- 09 Apr, 2019 11 commits
-
-
Hannah Stepanek authored
Previously, a test that should have failed passed when uri=null, because none of the test groups had uri patterns to check against. Make the test groups more realistic by adding in the scopes attribute for at least one of them.
-
Hannah Stepanek authored
In cases like: https://hypothes.is/a/rGSnNwCKSuiG3VT__k3VvA where the sidebar is not being used, the document uri is set to null in the groups service and passed to the combineGroups function. This means that the isScopedToUri logic must handle the case where uri=null.
-
Hannah Stepanek authored
-
Hannah Stepanek authored
Since the feature flag isn't available until the profile api request completes, and the profile api request is run asynchronously with the group api requests, it doesn't make sense to load conditionaly. Instead, call all the group api requests and filter the groups for the old groups menu later. In this case, filtering is done in the groups.all conditionally based on the feature flag.
-
Hannah Stepanek authored
Since the isScopedToUri is no longer dependent on scope enforcement and scope enforcement is now taken into account as part of whether a group is selectable or not, disableOosGroupSelection is no longer necessary. Group selection can be determined purely from isScopedToUri and scopes.enforced.
-
Hannah Stepanek authored
Previously, if the scope was not enforced, isScopedToUri would always return true. Now, isScopedToUri is true only when the scopes.uri_patterns match.
-
Hannah Stepanek authored
getInScopeGroups returns the list of groups for the old groups menu. Aka: only groups that are in scope are returned.
-
Hannah Stepanek authored
Revert "Remove feature flag from group service"
-
Hannah Stepanek authored
-
Hannah Stepanek authored
Remove feature flag from group service
-
Robert Knight authored
Convert `<svg-icon>` component to React
-