1. 14 Sep, 2023 2 commits
  2. 13 Sep, 2023 2 commits
    • Robert Knight's avatar
      Fix error if `matchShortcut` is called with non-KeyboardEvent · 54cae019
      Robert Knight authored
      Work around an exception when testing for shortcuts in `keydown` event handlers,
      if the handler is called with an argument that is not a `KeyboardEvent`, and is
      missing the expected `key` property. The workaround has been added to
      `matchShortcut` because it is easier to do there than remember for each
      `keydown` event handler, although there is a risk that other code in these
      handlers could get caught out by the same issue.
      
      I was able to reproduce this problem locally in Chrome 118 when using autofill
      to insert text into the search input field (see comments), though there might be
      other causes as well.
      
      This should fix https://hypothesis.sentry.io/issues/3987386810/?project=69811
      54cae019
    • Robert Knight's avatar
      Add missing null check for content frame in `ExportAnnotations` · 42858d04
      Robert Knight authored
      The `store.defaultContentFrame` selector had an incorrect return type, `Frame`
      instead of `Frame|null`, because `frames[0]` has the static type `Frame`, even
      though this can actually return undefined at runtime. As a result, TypeScript
      didn't catch a missing null check when generating the default filename for the
      export.
      
      Fixes https://github.com/hypothesis/client/issues/5818
      42858d04
  3. 12 Sep, 2023 1 commit
    • Robert Knight's avatar
      Add knowledge base links to Import / Export tabs · c01e96ec
      Robert Knight authored
       - Add links at the top of the Import and Export tabs to a knowledge base
         article with information about using these features for various workflows.
      
       - Use a `<label>` for the "Select Hypothesis export file", since it is
         logically a label. This label is associated to the file input via `htmlFor`,
         but note the custom file input will still read the fixed button text ("Select
         a file")
      
       - Make labels bold in Import / Export tab to make them stand out against the
         help text, and also for consistency with the "Share" tab
      
      Part of https://github.com/hypothesis/client/issues/5783
      c01e96ec
  4. 11 Sep, 2023 13 commits
  5. 08 Sep, 2023 1 commit
  6. 07 Sep, 2023 2 commits
  7. 05 Sep, 2023 1 commit
  8. 04 Sep, 2023 12 commits
  9. 01 Sep, 2023 4 commits
  10. 31 Aug, 2023 2 commits