- 11 Jan, 2021 1 commit
-
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.820.0 to 2.824.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.820.0...v2.824.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 08 Jan, 2021 2 commits
-
-
Kyle Keating authored
- Added override to button--icon-only mixin for min-size - Set the override value for menu__toggle to "inherit" This regression was caused when adding the buttons.button--icon-only mixin to the post annotation drop down toggle button (menu__toggle). This is indeed an icon button, but for visual fidelity, we are not going to bump the minimum size to the 44px in mobile view.
-
Lyza Danger Gardner authored
Fixes #2851
-
- 04 Jan, 2021 10 commits
-
-
Eduardo Sanz García authored
Previously, all users were able to click the flag icon. However, unauthenticated users were shown a toast message if they click the icon: `You must be logged in to report an annotation`. The behaviour has been changed so that the flag button is only shown (and clickable) for authenticated users. Resolves #1037
-
Lyza Danger Gardner authored
* It was unused * It had no tests * If there were tests, they might have kicked up that it's also buggy; it wasn't getting recalculated after threads were removed due to filtering For posterity: the equivalent is `thread.children.length`
-
dependabot-preview[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 8.2.1 to 8.2.2. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.2.1...8.2.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.30.0 to 1.32.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.30.0...1.32.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.5.7 to 10.5.9. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.5.7...10.5.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.1 to 3.8.2. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/compare/v3.8.1...v3.8.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.16.0 to 7.17.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.16.0...v7.17.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.817.0 to 2.820.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.817.0...v2.820.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.21.5 to 7.22.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.21.5...v7.22.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
https://github.com/hypothesis/h/pull/5862 introduced an optimization to startup of the sidebar app by preloading the `/api/` and `/api/links` requests. Because this change was made in h it only benefitted the embedded client, but not the browser extension. This commit moves the logic to add the `<link rel="preload">` links to the client's boot script. The upside of this is that it works with all distributions of the client and can be changed in future without needing to modify h and the browser extension etc. separately. The downside is that because the `<link>` is no longer in the sidebar app's HTML but in the boot script the prefetch will start a little later. Since Cloudflare caches the `/api/` and `/api/links` responses, these requests are still very likely to have completed by the time the client code starts executing.
-
- 28 Dec, 2020 1 commit
-
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.814.0 to 2.817.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.814.0...v2.817.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 26 Dec, 2020 3 commits
-
-
Kyle Keating authored
-
dependabot-preview[bot] authored
Bumps [browserify](https://github.com/browserify/browserify) from 16.5.2 to 17.0.0. - [Release notes](https://github.com/browserify/browserify/releases) - [Changelog](https://github.com/browserify/browserify/blob/master/changelog.markdown) - [Commits](https://github.com/browserify/browserify/compare/v16.5.2...v17.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.29.0 to 5.29.2. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.29.0...5.29.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 21 Dec, 2020 4 commits
-
-
dependabot-preview[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.10 to 7.12.11. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.11/packages/babel-preset-env) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.809.0 to 2.814.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.809.0...v2.814.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.2 to 2.2.6. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.2.2...2.2.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 7.15.0 to 7.16.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.15.0...v7.16.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 18 Dec, 2020 7 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
https://github.com/hypothesis/client/pull/2837 caused a regression where the initial annotation filters would be cleared after groups where fetched for the first time. This is because `SidebarView` had logic to clear the selection/filters when switching groups. This used to work because `SidebarView` was only rendered after groups were initially rendered. This is no longer the case after #2837. Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1608299842322000
-
- 17 Dec, 2020 3 commits
-
-
Robert Knight authored
Following https://github.com/hypothesis/client/pull/2837 the `SidebarView` component may now be rendered before the profile has been fetched. This component contains an effect which triggers the initial WebSocket connection. Since the WebSocket reconnects after the profile userid changes, this was causing the initial connection to almost immediately be disconnected if the user was logged in. Fix this by deferring the initial connection until after the profile has been fetched.
-
Robert Knight authored
Do not wait for groups and profile to load before calling `router.sync()` to set the initial route and thereby render the appropriate content component. Historically the main view components assumed that the user profile and groups were already loaded before they were rendered, but this is no longer the case. This fixes a brief flash of the sidebar's `TopBar` component inside the notebook when it initially loads. It also results in the `Annotations` and `Page Notes` tabs appearing immediately in the sidebar rather than waiting until the groups list is populated.
-
Robert Knight authored
`ThreadList` was measuring the height and scroll offset of the scroll container inside the render function instead of a layout effect. As a result it could fail if the scroll container is rendered by a parent component and its DOM has not yet been created. This issue was uncovered when trying to change the app to call `router.sync()` before waiting for `groups.load()` to complete. A test expectation had to be changed becaused it turned out that the scroll container had the wrong height when it was measured in the previous way (it was measured as 0px instead of the expected 350px).
-
- 16 Dec, 2020 6 commits
-
-
Robert Knight authored
There was no good reason for the separation between the two any more.
-
Robert Knight authored
- The logic for anchoring and generating range selectors provided by `range.js` has been replaced in `RangeAnchor`. - The normalization of DOM Ranges is no longer required by the rest of the code.
-
Robert Knight authored
Convert `RangeAnchor` to use `TextRange` and the XPath <-> Node mapping functions in xpath.js directly, rather than the `SerializedRange` and `NormalizedRange` classes. This change will mean that all conversion between text positions and (text node, offset) points in the client will use the same implementation. For `RangeAnchor` selectors this conversion is used for the `startOffset` and `endOffset` fields. The new implementation also avoids modifying the DOM, unlike the previous implementation which would sometimes split text nodes. Avoid DOM modifications during anchoring opens up the possibility of optimizing anchoring by caching text position <-> text node associations.
-
Robert Knight authored
https://github.com/hypothesis/client/pull/2818 inadvertently changed the size of the `.menu-toggle__icon` SVG element from 10x10px to 16x16px due to an `svg` selector introduced by the `buttons.button--icon-only` mixin taking precedence over the `.menu-toggle__icon` selector. As a result, the caret's vertical position was incorrect and it did not remain vertically centered when flipped. This commit nests the `.menu-toggle__icon` selector inside the parent `.menu-toggle` selector to restore the caret icon back to its 10x10 pixel size.
-
Robert Knight authored
Fix a typechecking error in `useRootThread`. `@return` has no effect when used above a variable initialized to a value that is not an arrow function or function expression. Therefore the type was inferred based on the `filterValues` local variable to be `{}`. Correct this to `Object.<string,string>` so that it matches up with the `ThreadState` type.
-
Robert Knight authored
Remove the need to define the type of store created by each module manually by adding a `StoreFromModule` helper in `create-store.js` which can infer the store type from a store module configuration. Using this the type of a store composed from several modules can then be created with: ``` import fooModule from './modules/foo'; import barModule from './modules/bar'; // Define type of store returned by `createStore([fooModule, barModule])` /** @typedef {StoreType<fooModule> & StoreType<barModule>} AppStore */ ``` Ideally `createStore` would just infer the type based upon its arguments. I haven't worked out how to do that yet. Nevertheless, this still removes the need for a lot of manually defined types. To ensure more useful error messages from TS if a store module's configuration has the wrong shape a `storeModule` helper has been added. This wraps the configuration for each module to check its shape before the individual modules are combined into one type for the store. This helper could also perform runtime validation in future. - Add `StoreFromModule` type in `create-store.js` and several helpers to support it - Modify each store module to wrap the export in `storeModule` and remove any manually defined store types
-
- 15 Dec, 2020 1 commit
-
-
Kyle Keating authored
- Fix issue where clicking the menu background showed a focus ring - Fix issue where buttons in the top-bar were not animating back from hover color - Prevent button animation from being applied to focus ring styling (caused issue in safari)
-
- 14 Dec, 2020 2 commits
-
-
Lyza Danger Gardner authored
Restructure the filters store module with the following goals in mind: * Simplify the structure of user-focus mode * Make the filtering structure for user-focus filters consistent with other filters * Add some actions and selectors for setting and getting filters, clearing the way to start adding some additional filtering * Be explicit about filter precedence Only one change here that affects the store's API and that is adjusted for in `useRootThread`.
-
dependabot-preview[bot] authored
Bumps [karma-browserify](https://github.com/nikku/karma-browserify) from 7.0.0 to 8.0.0. - [Release notes](https://github.com/nikku/karma-browserify/releases) - [Commits](https://github.com/nikku/karma-browserify/compare/v7.0.0...v8.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-