• Robert Knight's avatar
    Move scroll container measuring into a layout effect · eaaddb46
    Robert Knight authored
    `ThreadList` was measuring the height and scroll offset of the scroll
    container inside the render function instead of a layout effect. As a result
    it could fail if the scroll container is rendered by a parent component
    and its DOM has not yet been created.
    
    This issue was uncovered when trying to change the app to call
    `router.sync()` before waiting for `groups.load()` to complete.
    
    A test expectation had to be changed becaused it turned out that the
    scroll container had the wrong height when it was measured in the
    previous way (it was measured as 0px instead of the expected 350px).
    eaaddb46
Name
Last commit
Last update
..
annotation-action-bar-test.js Loading commit data...
annotation-body-test.js Loading commit data...
annotation-document-info-test.js Loading commit data...
annotation-editor-test.js Loading commit data...
annotation-header-test.js Loading commit data...
annotation-publish-control-test.js Loading commit data...
annotation-quote-test.js Loading commit data...
annotation-share-control-test.js Loading commit data...
annotation-share-info-test.js Loading commit data...
annotation-test.js Loading commit data...
annotation-timestamps-test.js Loading commit data...
annotation-user-test.js Loading commit data...
annotation-view-test.js Loading commit data...
autocomplete-list-test.js Loading commit data...
button-test.js Loading commit data...
excerpt-test.js Loading commit data...
filter-status-test.js Loading commit data...
group-list-item-test.js Loading commit data...
group-list-section-test.js Loading commit data...
group-list-test.js Loading commit data...
help-panel-test.js Loading commit data...
hypothesis-app-test.js Loading commit data...
logged-out-message-test.js Loading commit data...
login-prompt-panel-test.js Loading commit data...
markdown-editor-test.js Loading commit data...
markdown-view-test.js Loading commit data...
menu-item-test.js Loading commit data...
menu-keyboard-navigation-test.js Loading commit data...
menu-section-test.js Loading commit data...
menu-test.js Loading commit data...
moderation-banner-test.js Loading commit data...
new-note-btn-test.js Loading commit data...
notebook-view-test.js Loading commit data...
search-input-test.js Loading commit data...
selection-tabs-test.js Loading commit data...
share-annotations-panel-test.js Loading commit data...
share-links-test.js Loading commit data...
sidebar-content-error-test.js Loading commit data...
sidebar-panel-test.js Loading commit data...
sidebar-view-test.js Loading commit data...
slider-test.js Loading commit data...
sort-menu-test.js Loading commit data...
spinner-test.js Loading commit data...
stream-search-input-test.js Loading commit data...
stream-view-test.js Loading commit data...
tag-editor-test.js Loading commit data...
tag-list-test.js Loading commit data...
thread-card-test.js Loading commit data...
thread-list-test.js Loading commit data...
thread-test.js Loading commit data...
toast-messages-test.js Loading commit data...
top-bar-test.js Loading commit data...
tutorial-test.js Loading commit data...
user-menu-test.js Loading commit data...
version-info-test.js Loading commit data...