• Robert Knight's avatar
    Scroll correct Element when scrolling a thread into view · 03ab296f
    Robert Knight authored
    Since the `<thread-list>` is now contained within a scrollable element
    which is not `document.body`, it needs to scroll that element rather
    than the window in order to scroll the element into view.
    
     * Remove the hard-coded selector used to find the scroll root and
       instead search for the closest ancestor element to the
       `<thread-list>` whose computed style has `overflowY` set to `scroll`.
     * Set the scroll root Element's `scrollTop` to scroll the thread list
       instead of calling `window.scroll`
     * Compute the maximum scroll offset based on the `scrollTop` and
       `scrollHeight` properties of the scroll root element instead of
       using `document.body.scrollHeight`.
     * Update tests for `<thread-list>` to check for the scrollable
       ancestor being scrolled instead of the window.
    03ab296f
Name
Last commit
Last update
..
integration Loading commit data...
analytics-test.js Loading commit data...
annotation-fixtures.js Loading commit data...
annotation-mapper-test.js Loading commit data...
annotation-metadata-test.js Loading commit data...
annotation-ui-test.js Loading commit data...
auth-test.js Loading commit data...
bootstrap.js Loading commit data...
build-thread-test.js Loading commit data...
drafts-test.js Loading commit data...
fake-redux-store.js Loading commit data...
features-test.js Loading commit data...
form-respond-test.coffee Loading commit data...
frame-sync-test.js Loading commit data...
groups-test.js Loading commit data...
host-config-test.js Loading commit data...
host-test.coffee Loading commit data...
local-storage-test.coffee Loading commit data...
markdown-commands-test.js Loading commit data...
media-embedder-test.js Loading commit data...
oauth-auth-test.js Loading commit data...
permissions-test.coffee Loading commit data...
raven-test.js Loading commit data...
render-markdown-test.js Loading commit data...
retry-util-test.js Loading commit data...
root-thread-test.js Loading commit data...
search-client-test.js Loading commit data...
search-filter-test.coffee Loading commit data...
service-config-test.js Loading commit data...
service-url-test.js Loading commit data...
session-test.js Loading commit data...
store-test.js Loading commit data...
streamer-test.js Loading commit data...
tabs-test.js Loading commit data...
tags-test.coffee Loading commit data...
time-test.js Loading commit data...
unicode-test.coffee Loading commit data...
view-filter-test.coffee Loading commit data...
virtual-thread-list-test.js Loading commit data...
websocket-test.js Loading commit data...