• Robert Knight's avatar
    Allow draft annotations to match filters · 19fc6f7f
    Robert Knight authored
    The internal function that filters annotations returned a list of matching IDs.
    Unsaved annotations do not have IDs, so were excluded from the matches. Change
    the function to return a list of matching annotations instead, lifting this
    restriction.
    
    No callers of the function had to change because currently they only test the
    length of the returned array.
    
    A caveat with this change is that it only matches the data stored in the
    annotation object, not data stored in separate "draft" objects which are
    combined when rendering unsaved annotations. The result is that a filter will
    only match the fields of the annotation that are populated when the new
    annotation initially appears in the sidebar. This for example includes the user
    and page number, but not text added in the text field later.
    19fc6f7f
Name
Last commit
Last update
.github Loading commit data...
.yarn Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
.readthedocs.yaml Loading commit data...
.yarnrc.yml Loading commit data...
HACKING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
pyproject.toml Loading commit data...
rollup-boot.config.js Loading commit data...
rollup-tests.config.js Loading commit data...
rollup.config.js Loading commit data...
tailwind-annotator.config.js Loading commit data...
tailwind-sidebar.config.js Loading commit data...
tailwind.config.js Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...