• Robert Knight's avatar
    Extract `quote` function from annotation / view-filter · d4374884
    Robert Knight authored
    Both `components/annotation` and `view-filter` modules had logic and
    tests for extracting a quote from an annotation object. Extract these
    into a shared `quote` function in `util/annotation-metadata`.
    
    One small change is that `view-filter`'s implementation allowed
    annotation objects with _no_ `target` property. These should never
    occur. There is a known issue where creating a Page Note results in an
    annotation with an _empty_ `target` property until the annotation is
    saved (see [1]). That case, which is still handled, looks like a mistake,
    but resolving it is outside the scope of this change.
    
    [1] https://github.com/hypothesis/client/issues/1290
    d4374884
Name
Last commit
Last update
..
annotation-action-button-test.js Loading commit data...
annotation-body-test.js Loading commit data...
annotation-document-info-test.js Loading commit data...
annotation-header-test.js Loading commit data...
annotation-publish-control-test.js Loading commit data...
annotation-quote-test.js Loading commit data...
annotation-share-control-test.js Loading commit data...
annotation-share-info-test.js Loading commit data...
annotation-test.js Loading commit data...
annotation-thread-test.js Loading commit data...
annotation-user-test.js Loading commit data...
annotation-viewer-content-test.js Loading commit data...
excerpt-test.js Loading commit data...
focused-mode-header-test.js Loading commit data...
group-list-item-test.js Loading commit data...
group-list-section-test.js Loading commit data...
group-list-test.js Loading commit data...
help-panel-test.js Loading commit data...
hypothesis-app-test.js Loading commit data...
logged-out-message-test.js Loading commit data...
markdown-editor-test.js Loading commit data...
markdown-view-test.js Loading commit data...
menu-item-test.js Loading commit data...
menu-section-test.js Loading commit data...
menu-test.js Loading commit data...
mock-imported-components.js Loading commit data...
moderation-banner-test.js Loading commit data...
new-note-btn-test.js Loading commit data...
search-input-test.js Loading commit data...
search-status-bar-test.js Loading commit data...
selection-tabs-test.js Loading commit data...
share-annotations-panel-test.js Loading commit data...
share-links-test.js Loading commit data...
sidebar-content-error-test.js Loading commit data...
sidebar-content-test.js Loading commit data...
sidebar-panel-test.js Loading commit data...
slider-test.js Loading commit data...
sort-menu-test.js Loading commit data...
spinner-test.js Loading commit data...
stream-content-test.js Loading commit data...
stream-search-input-test.js Loading commit data...
svg-icon-test.js Loading commit data...
tag-editor-test.js Loading commit data...
thread-list-test.js Loading commit data...
timestamp-test.js Loading commit data...
top-bar-test.js Loading commit data...
tutorial-test.js Loading commit data...
user-menu-test.js Loading commit data...
version-info-test.js Loading commit data...