• Robert Knight's avatar
    Don't close sidebar when clicking on bucket bar background · 34521471
    Robert Knight authored
    Prevent the sidebar from closing when clicking the grey background behind
    buckets or toolbar buttons. Visually this background is part of the sidebar, so
    it seems unexpected that clicking it closes the sidebar.  Also if a user misses
    a bucket's hit target, it is annoying if the sidebar gets closed and moves the
    bucket/button.
    
    Remove the `pointer-events: none` style from the grey background behind the
    bucket bar. As a result clicks on this background will go to this background
    element instead of the document content behind it. Due to existing logic in the
    `createShadowRoot` helper, `mousedown` events within `<hypothesis-*>` element
    shadow roots have their propagation stopped and so they don't reach the code in
    `Guest` which closes the sidebar.
    34521471
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
.readthedocs.yaml Loading commit data...
HACKING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.mjs Loading commit data...
package.json Loading commit data...
pyproject.toml Loading commit data...
rollup-boot.config.mjs Loading commit data...
rollup-tests.config.mjs Loading commit data...
rollup.config.mjs Loading commit data...
tailwind-annotator.config.mjs Loading commit data...
tailwind-sidebar.config.mjs Loading commit data...
tailwind.config.mjs Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...