• Robert Knight's avatar
    Refactor side-by-side state in Guest · 1475c104
    Robert Knight authored
    In issue discussions, tests and various parts of the code there are
    mentions of side-by-side mode being active or not. The `Guest` class
    didn't store this state directly but instead had a
    `closeSidebarOnDocumentClick` state which is always the inverse of
    "is side-by-side active?".
    
    Make the code easier to follow by storing the "is side-by-side active?" state
    directly. This will also avoid a misnamed variable if in future the
    state has other effects besides changing whether clicking on the
    document closes the sidebar.
    
     - Replace `closeSidebarOnDocumentClick` with a private
       `_sideBySideActive` property, exposed via a read-only
       `sideBySideActive` getter
    
     - Refactor tests to only use the public API of Guest (calling
       `Guest#fitSideBySide` or reading `sideBySideActive`)
    1475c104
Name
Last commit
Last update
..
anchoring Loading commit data...
components Loading commit data...
config Loading commit data...
integrations Loading commit data...
test Loading commit data...
util Loading commit data...
.eslintrc.js Loading commit data...
adder.js Loading commit data...
annotation-counts.js Loading commit data...
annotation-sync.js Loading commit data...
bucket-bar.js Loading commit data...
cross-frame.js Loading commit data...
features.js Loading commit data...
frame-observer.js Loading commit data...
guest.js Loading commit data...
highlighter.js Loading commit data...
icons.js Loading commit data...
index.js Loading commit data...
notebook.js Loading commit data...
range-util.js Loading commit data...
selection-observer.js Loading commit data...
sidebar-trigger.js Loading commit data...
sidebar.js Loading commit data...
toolbar.js Loading commit data...