• Robert Knight's avatar
    Convert `Excerpt` component to Preact · d1485d0b
    Robert Knight authored
    Convert the `Excerpt` component to Preact. Rather than convert the
    existing implementation verbatim, this is a completely new implementation which
    should be easier to understand and use. Instead of requiring callers to
    provide an input property which represents the displayed data, which triggers a
    re-measurement if it changes, the new implementation observes the DOM
    directly for size changes.
    
    This component renders caller-provided content (ie. it accepts a `children`
    prop), which is not supported by the Preact <-> Angular bridge. Therefore it was
    also necessary to create components (`AnnotationBody`, `AnnotationQuote`) that
    encapsulate uses of `Excerpt` inside the `<annotation>` component.
    
     - Add `observe-element-size` utility module to watch for changes in
       the size of a DOM node using APIs available in the current browser
    
     - Add new `Excerpt` implementation and remove the old one
    
     - Remove `excerpt-overflow-monitor` utility that is not used by the new
       implementation
    
     - Add `AnnotationBody` component to render an annotation's markup body
       inside a (new) excerpt and convert the Angular template for
       `<annotation>` (annotation.html) to use it.
    
     - Add `AnnotationQuote` component to render an annotation's quote
       inside an excerpt and convert `annotation.html` to use it
    d1485d0b
Name
Last commit
Last update
..
account-id-test.js Loading commit data...
annotation-metadata-test.js Loading commit data...
copy-to-clipboard-test.js Loading commit data...
disable-opener-for-external-links-test.js Loading commit data...
dom-test.js Loading commit data...
fake-window.js Loading commit data...
fetch-config-test.js Loading commit data...
group-list-item-common-test.js Loading commit data...
group-organizations-test.js Loading commit data...
groups-test.js Loading commit data...
is-sidebar-test.js Loading commit data...
is-third-party-service-test.js Loading commit data...
memoize-test.js Loading commit data...
oauth-client-test.js Loading commit data...
observer-element-size-test.js Loading commit data...
postmessage-json-rpc-test.js Loading commit data...
random-test.js Loading commit data...
retry-test.js Loading commit data...
scope-timeout-test.js Loading commit data...
sentry-test.js Loading commit data...
service-context-test.js Loading commit data...
session-util-test.js Loading commit data...
state-util-test.js Loading commit data...
tabs-test.js Loading commit data...
theme-test.js Loading commit data...
time-test.js Loading commit data...
url-util-test.js Loading commit data...
version-data-test.js Loading commit data...
wrap-react-component-test.js Loading commit data...