• Robert Knight's avatar
    Implement new design for hovered conversation threads (#3376) · a3f910d3
    Robert Knight authored
    * Implement new design for hovered conversation threads
    
    Implement the new design for hovered replies from
    https://trello.com/c/aXCXxzx2 .
    
    The most visible effect is that conversation threads have a grey
    background when hovered.
    
    In the process of implementing the new styling, there is some cleanup
    of the CSS:
    
     * Use `--reply`/`--top-reply` modifier classes on <annotation> and
       <annotation-thread> elements to style annotations, top-level replies
       and nested replies differently. This makes the CSS simpler and
       reduces the risk of unexpected side effects that come with descendant
       selectors.
    
     * Rename `thread` CSS classes to match the name of the component
       that they are used in, `annotation-thread`.
    
    * Move 'annotation-unavailable-message' styling to app.scss
    
    This class is used in the root template (viewer.html) not the
    <annotation-thread> component.
    
    * Darken expand/collapse toggle arrow only when annotation itself is hovered
    
    Darken the expand/collapse arrow when an annotation is hovered but not
    when its replies are hovered.
    
    * Remove no-op CSS class
    
    The `clear: both` styling had no effect because <annotation-thread>
    is now using flexbox rather than floats for layout.
    
    * Do not show 'Hide replies' link for replies
    
    For replies there were two different ways to collapse the annotation
    card, the expand/collapse toggle arrow and the 'Hide replies' link.
    
    Removing the 'Hide replies' link avoids having two ways to do the same
    thing and makes the cards look cleaner.
    
    * Remove the light grey background for hovered replies
    
    Following design review, remove the grey background for hovered replies.
    
    * Make rendering of dashed lines to the left of replies better in Chrome
    
    Previously the dashed line started at the top of the <annotation-thread>
    component and the top part was covered up by the thread expand/collapse
    toggle.
    
    In Chrome the alignment of dashes within a dashed border varies as the
    height of the element changes [1]. Therefore depending on the height of
    the reply, this could result in the visible part of the line below the
    collapse/expand toggle starting at either a gap or dash in the line.
    
    By instead moving the dashed line to a separate element which is
    positioned beneath the expand/collapse toggle, the first visible dash in
    the reply line always appears in the same place and is aligned correctly
    with the annotation content to its right.
    
    [1] See http://www.impressivewebs.com/comparison-css-border-style/
        for a visual representation of why this is done.
    a3f910d3
Name
Last commit
Last update
..
integration Loading commit data...
admin-users-test.js Loading commit data...
annotation-fixtures.js Loading commit data...
annotation-mapper-test.js Loading commit data...
annotation-metadata-test.js Loading commit data...
annotation-sync-test.coffee Loading commit data...
annotation-ui-controller-test.js Loading commit data...
annotation-ui-sync-test.js Loading commit data...
annotation-ui-test.js Loading commit data...
annotation-viewer-controller-test.js Loading commit data...
app-controller-test.js Loading commit data...
auth-test.js Loading commit data...
bootstrap.js Loading commit data...
bridge-test.coffee Loading commit data...
build-thread-test.js Loading commit data...
create-group-form-test.js Loading commit data...
cross-frame-test.coffee Loading commit data...
discovery-test.coffee Loading commit data...
drafts-test.js Loading commit data...
empty.html Loading commit data...
features-test.js Loading commit data...
form-respond-test.coffee Loading commit data...
form-select-onfocus-controller-test.js Loading commit data...
groups-test.js Loading commit data...
host-test.coffee Loading commit data...
installer-controller-test.js Loading commit data...
local-storage-test.coffee Loading commit data...
login-form-test.coffee Loading commit data...
markdown-commands-test.js Loading commit data...
media-embedder-test.js Loading commit data...
page-test.js Loading commit data...
permissions-test.coffee Loading commit data...
promise-util.js Loading commit data...
raven-test.js Loading commit data...
render-markdown-test.js Loading commit data...
retry-util-test.js Loading commit data...
root-thread-test.js Loading commit data...
search-client-test.js Loading commit data...
search-filter-test.coffee Loading commit data...
session-test.js Loading commit data...
settings-test.js Loading commit data...
store-test.js Loading commit data...
stream-controller-test.coffee Loading commit data...
streamer-test.js Loading commit data...
tags-test.coffee Loading commit data...
time-test.js Loading commit data...
unicode-test.coffee Loading commit data...
util.js Loading commit data...
view-filter-test.coffee Loading commit data...
virtual-thread-list-test.js Loading commit data...
websocket-test.js Loading commit data...
widget-controller-test.js Loading commit data...