• Lyza Danger Gardner's avatar
    Adjust UI for sharing annotations on non-shareable documents · 53b33217
    Lyza Danger Gardner authored
    In both the share-this-annotation and share-this-page's-annotations
    components, provide a UI path for when the annotation's URI or the
    page's URI (respectively) are not web-available. That is, to be
    "shareable in context", the URI in question needs to have an
    `http:` or `https:` protocol.
    
    For "share this page's annotations" when the page is not web-accessible,
    explain why the page's annotations can't be shared in context and don't
    provide a sharing link, as it won't work.
    
    For "share this annotation," when the annotation's URI (document) isn't
    web-accessible, provide some explanatory text about how it can't be
    shared in-context, but provide a link to the single-annotation view,
    when available.
    
    These changes are intended to avoid confusion when users try to share an
    annotation or a set of annotations that have been made on a local
    (e.g. PDF) document.
    
    Some SCSS patterns have also been adjusted to accommodate more flexible
    styling of the share-single-annotation panel. The width of the compact
    panel pattern has been increased slightly so that the new wording
    variant for not-shareable-in-context single annotations doesn't risk
    taking up too much vertical space.
    
    Fixes #2786
    53b33217
Name
Last commit
Last update
..
account-id-test.js Loading commit data...
annotation-metadata-test.js Loading commit data...
annotation-sharing-test.js Loading commit data...
build-thread-test.js Loading commit data...
collections-test.js Loading commit data...
copy-to-clipboard-test.js Loading commit data...
disable-opener-for-external-links-test.js Loading commit data...
dom-test.js Loading commit data...
fake-window.js Loading commit data...
fetch-config-test.js Loading commit data...
group-list-item-common-test.js Loading commit data...
group-organizations-test.js Loading commit data...
groups-test.js Loading commit data...
immutable-test.js Loading commit data...
is-sidebar-test.js Loading commit data...
is-third-party-service-test.js Loading commit data...
memoize-test.js Loading commit data...
oauth-client-test.js Loading commit data...
observe-element-size-test.js Loading commit data...
permissions-test.js Loading commit data...
postmessage-json-rpc-test.js Loading commit data...
random-test.js Loading commit data...
retry-test.js Loading commit data...
search-filter-test.js Loading commit data...
sentry-test.js Loading commit data...
service-context-test.js Loading commit data...
session-test.js Loading commit data...
state-test.js Loading commit data...
tabs-test.js Loading commit data...
theme-test.js Loading commit data...
thread-annotations-test.js Loading commit data...
thread-test.js Loading commit data...
time-test.js Loading commit data...
unicode-test.js Loading commit data...
url-test.js Loading commit data...
version-data-test.js Loading commit data...
view-filter-test.js Loading commit data...
visible-threads-test.js Loading commit data...
watch-test.js Loading commit data...