• Robert Knight's avatar
    Remove fallback document URL and metadata · 56737601
    Robert Knight authored
    Remove the fallback logic that uses `location.href` and `document.title`
    as the document URL and metadata if using the integration-specific code
    (HTML or PDF) to get the document URL and metadata fails. Instead just
    let the async exception propagate.  Currently this will result in no
    annotation/highlight being created and a console error. In future we
    should improve this by showing an error notification to the user.
    
    Recording the wrong document metadata with an annotation is worse than
    not creating an annotation at all: The user will be unaware that there
    is a problem yet the annotation will likely fail to show up in future or
    be displayed with completely wrong metadata in the Notebook. Therefore
    we want the failure here to be obvious so that the user notifies us of
    the problem and doesn't create a bunch of annotations which later
    "disappear".
    
    Fixes #3204
    56737601
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...