• Robert Knight's avatar
    Fix scrolling to annotations in un-rendered pages · 5fbf8a11
    Robert Knight authored
    When scrolling to an anchor in a page that has not been rendered by
    PDF.js, the anchor actually references a placeholder element in the
    middle of the page. In order to scroll to the correct location in the
    page scrolling for such anchors needs to happen in three phases:
    
     1. Scroll to the approximate location of the final anchor, given by the
        placeholder anchor. This will trigger PDF.js to re-render the target
        page.
     2. Wait for PDF.js to finish re-rendering the page and for the client
        to finish re-anchoring the annotation.
     3. Scroll to the real/non-placeholder anchor.
    
    Change `PDFIntegration#scrollToAnchor` to implement the above steps.
    
    Fixes https://github.com/hypothesis/client/issues/3269
    5fbf8a11
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...