• Robert Knight's avatar
    Make boot script load settings from correct config tags (#243) · 68be70df
    Robert Knight authored
    An inconsistency crept in where the annotator code reads settings from
    JSON script tags with a 'js-hypothesis-config' class name but the sidebar app
    reads settings from JSON script tags with a 'js-hypothesis-settings'
    class name. The boot script ended up using 'js-hypothesis-settings'
    which is the default class name specified in `settings.js`.
    
    We should use the same name everywhere, which needs to be
    'js-hypothesis-config' since that is used by the public documentation
    [1].
    
    This commit changes the default class to `js-hypothesis-config` and
    removes the ability to specify alternative class names when calling
    `settings()`.
    
    The extension and service will need to be updated to use the new class
    name.
    
    [1] See docs/config.md
    68be70df
Name
Last commit
Last update
.github Loading commit data...
docs Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.travis.yml Loading commit data...
CHANGELOG.md Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
gulpfile.js Loading commit data...
npm-shrinkwrap.json Loading commit data...
package.json Loading commit data...