• Robert Knight's avatar
    Replace the `BEFORE_ANNOTATION_CREATED` event · 75a0e8aa
    Robert Knight authored
    The `BEFORE_ANNOTATION_CREATED` event was used for two purposes:
    
     1. Invoke `annotationsService.create(...)` to create the annotation in
        the sidebar.
     2. Scroll the newly created annotation into view
    
    Resolve (1) by calling `annotationsService.create` directly from the
    `frameSync` service and resolve (2) by watching for changes to
    `unsavedAnnotations()` in the store and scrolling to the new annotation
    when it appears.
    
    There is one functional change which is that replies will be scrolled
    into view, as this seems like a useful behavior if the user clicks the
    "Reply" button for a thread and the input field appears below the bottom
    of the screen.
    75a0e8aa
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.prettierrc Loading commit data...
.python-version Loading commit data...
.travis.yml Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
yarn.lock Loading commit data...