• Robert Knight's avatar
    Avoid String.prototype.startsWith() for compatibility Safari and IE · 2ec367eb
    Robert Knight authored
    Links to source document URIs were broken under Safari <= 8 and
    other browsers as well due to reliance on the
    String.prototype.startsWith() API
    
    This issue went unnoticed in Karma/PhantomJS tests because
    Karma was primed with the complete set of polyfills from
    the js-polyfills library, including many (all?) ES6 polyfills.
    
    This same set of polyfills was_not_ used in the browser build however.
    
    This commit fixes the original issue by using 'indexOf()' instead of
    'startsWith()' and reduces the likelihood of such problems going
    unnoticed during testing by using a much more minimal set of polyfills
    under PhantomJS.
    
    The alternative approach would be to go in the opposite direction
    and polyfill any ES6 APIs in the browser. However, we need to be
    careful about code bloat, so the approach taken here is the more
    conservative option.
    
    Fixes #2568
    2ec367eb
Name
Last commit
Last update
..
account Loading commit data...
annotator Loading commit data...
config Loading commit data...
directive Loading commit data...
filter Loading commit data...
test Loading commit data...
vendor Loading commit data...
annotation-mapper.js Loading commit data...
annotation-sync.coffee Loading commit data...
annotation-ui-controller.coffee Loading commit data...
annotation-ui-sync.coffee Loading commit data...
annotation-ui.coffee Loading commit data...
annotation-viewer-controller.coffee Loading commit data...
app-controller.coffee Loading commit data...
app.coffee Loading commit data...
auth.js Loading commit data...
blocklist.js Loading commit data...
bridge.coffee Loading commit data...
cross-frame.coffee Loading commit data...
discovery.coffee Loading commit data...
drafts.coffee Loading commit data...
features.js Loading commit data...
flash.coffee Loading commit data...
form-respond.coffee Loading commit data...
groups.js Loading commit data...
host.coffee Loading commit data...
identity.coffee Loading commit data...
karma-phantomjs-polyfill.js Loading commit data...
karma.config.js Loading commit data...
local-storage.coffee Loading commit data...
permissions.coffee Loading commit data...
pulse.coffee Loading commit data...
query-parser.coffee Loading commit data...
render.coffee Loading commit data...
search-filter.coffee Loading commit data...
service-url.js Loading commit data...
session.js Loading commit data...
store.coffee Loading commit data...
stream-controller.coffee Loading commit data...
stream-filter.coffee Loading commit data...
tags.coffee Loading commit data...
threading.coffee Loading commit data...
time.coffee Loading commit data...
ui-bootstrap-custom.js Loading commit data...
unicode.coffee Loading commit data...
view-filter.coffee Loading commit data...
widget-controller.coffee Loading commit data...