• Robert Knight's avatar
    Fix failure to fetch groups in VitalSource · ab548854
    Robert Knight authored
    Before loading groups the client waits for the main document frame to connect in
    order to be able to fetch groups associated with that frame's URL. In
    VitalSource however there is no "main frame", only the current content frame, so
    `GroupsService._loadGroupsForUserAndDocument` waited indefinitely.
    
    This failure to fetch groups did not happen on the initial launch due to a
    different bug in `GroupsService._loadGroupsForUserAndDocument`. The
    `this_store.route()` call returned `null` during startup and hence the code did
    not wait for the main frame to connect. After a subsequent login/logout however,
    the `route` call returned "sidebar" and the code did wait for the main frame.
    
    This problem also did not happen in the LMS environment because there the client
    loads a set of groups specified by our LMS app, instead of fetching groups based
    on the logged-in user and current document.
    
    Solve the first problem by using the `defaultContentFrame` method to get the
    frame instead of `mainFrame`. `defaultContentFrame` returns the main frame if
    there is one, or the first content frame that connected otherwise.
    ab548854
Name
Last commit
Last update
..
annotator Loading commit data...
boot Loading commit data...
images/icons Loading commit data...
shared Loading commit data...
sidebar Loading commit data...
styles Loading commit data...
test-util Loading commit data...
types Loading commit data...
karma.config.cjs Loading commit data...
tsconfig.json Loading commit data...