• Robert Knight's avatar
    Work around Chrome bug causing sidebar to become invisible · 325741fb
    Robert Knight authored
    Work around a Chrome bug [1] that can cause the sidebar to become
    invisible if:
    
     1. The sidebar app is loaded from a Chrome extension AND
     2. The current tab was opened by clicking a link inside the sidebar
        app in a different tab.
    
    When the issue occurs, the sidebar web app loads and runs normally but
    is just not visible on screen. This happens due to an internal issue in
    Chrome which can be avoided adding `rel="noopener"` to all "normal" [2]
    links in the client that open URLs in a new tab/window.
    
    Doing so enables Chrome to use a separate process for the Hypothesis
    client in the new tab in step (2) than the one used for the Hypothesis
    client in step (1). This change also prevents potential tab-jacking
    attacks in all browsers that support `rel="noopener"`.
    
    Fixes #516
    
    [1] https://bugs.chromium.org/p/chromium/issues/detail?id=753314
    [2] ie. Those which do not use JS to handle the link
    325741fb
Name
Last commit
Last update
.github Loading commit data...
docs Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.travis.yml Loading commit data...
CHANGELOG.md Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
gulpfile.js Loading commit data...
package-lock.json Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
yarn.lock Loading commit data...