• Robert Knight's avatar
    Fix real-time update action processing · 9479612f
    Robert Knight authored
    When store modules were refactored to only receive their local state in
    selectors, the code in `store/modules/real-time-updates` which directly
    uses selectors from other modules rather than calling
    `store.<selectorMethod>(...)` was not updated to pass in the appropriate
    part of the state.
    
    Fixing this resolves two problems:
    
     - An error when processing notifications of deleted annotations from
       the server. These notifications are currently not getting delivered
       due to a server-side issue (see https://github.com/hypothesis/h/pull/6214).
    
     - Filtering notifications of new or updated annotations not excluding
       annotations from groups that are not currently focused.
    
       Fixing this second issue has the side effect that it _appears_ to fix
       https://github.com/hypothesis/support/issues/137 from the user's
       point of view. I say _appears to_ because the backend is still
       incorrectly delivering notifications that the user shouldn't be able
       to see. That is fixed by https://github.com/hypothesis/h/pull/6202
    9479612f
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.prettierrc Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
yarn.lock Loading commit data...