• Robert Knight's avatar
    Move scroll-to-highlight logic into integrations · 9bec434d
    Robert Knight authored
    Move the logic for scrolling the content to the highlights associated
    with an anchor from `Guest` to the content-type specific integration
    (`HTMLIntegration`, `PDFIntegration`). The implementations of this logic
    in `HTMLIntegration` and `PDFIntegration` are currently the same as
    before, but in future this will allow adapting the scrolling logic to
    the content type.
    
    In the case of PDFs the logic will need to allow for the fact that an
    annotation may be re-anchored to a different element as the document is
    scrolled due to the page containing the annotation changing between an
    un-rendered and rendered state.
    
     - Add `scrollToAnchor` method to `Integration` interface and implement
       it for `HTMLIntegration`, `PDFIntegration`
     - Replace `scrollIntoView` call in guest with a call to the active
       integration's `scrollToAnchor` method
    9bec434d
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...