• Robert Knight's avatar
    Don't try to resolve sidebar app URL when booting sidebar app · 9d0621df
    Robert Knight authored
    When attempting to create a build of the browser extension using the
    local dev client and the production h service I encountered an issue where
    resolving the `sidebarAppUrl` setting in `src/boot/index.js` failed.
    
    This happens because the extension does not set this setting in the
    sidebar app so the boot script fell back to trying to resolve the URL
    template baked into the development client. This in turn failed
    because `document.currentScript` is not set in this context.
    
    The `sidebarAppUrl` setting is not actually needed when booting the sidebar app, so
    this commit refactors the boot code to avoid generating it in this
    context. This is done by moving the responsibility for determining which
    part of the client to load from `boot/boot.js` into `boot/index.js` and
    only resolving the necessary settings.
    9d0621df
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.prettierrc Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
yarn.lock Loading commit data...