• Sean Hammond's avatar
    Update an out-of-date fake · b7e5cc3c
    Sean Hammond authored
    The fakeAccountID object in annotation-test.js was out of date: it
    contained only a username() function that annotation.js doesn't call
    anymore, and did not contain the isThirdPartyUser() function that
    annotation.js _does_ call.
    
    The tests were still passing because annotation.js's isThirdPartyUser()
    method, which call's account-id's isThirdPartyUser(), wasn't tested. Add
    an integration test for this method to catch this.
    
    I've also moved fakeAccountID out into its own variable with a name,
    instead of it just being an anonymous object literal. This makes it more
    explicit. For example if account-id's API is changed, you can just grep
    the code for fakeAccountID to find all the fakes that need to be
    updated.
    b7e5cc3c
Name
Last commit
Last update
.github Loading commit data...
docs Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.travis.yml Loading commit data...
CHANGELOG.md Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
yarn.lock Loading commit data...