• Robert Knight's avatar
    Refactor profile data access in the store · 2ec09cad
    Robert Knight authored
    This PR refactors accessing and updating of profile data from
    `/api/profile` in the store:
    
     - Always access the profile data fetched from `/api/profile` via the
       `store.profile()` selector rather than using
       `store.getState().session...`.
    
     - Move the profile data from the top level of `state.session` into a
       `profile` field (`state.session.profile`)
    
     - Rename `store.updateSession()` to `store.updateProfile()` for
       consistency with the `profile()` selector. The previous name is a
       holdover from when "session" meant "the user's cookie session".
    
    These changes make this store module follow our agreed best practices to
    avoid accessing state directly, rather than via a selector, and will also
    make it easier to add additional session-related state in future which
    is not fetched from `/api/profile`.
    
    One subtle but intended change is that `state.session.profile` is now
    always _replaced_ when the profile is udpated, rather than it being the
    result of merging the previous and current state. The previous behavior
    could introduce subtle bugs where state from a previous login remained
    after switching the user.
    2ec09cad
Name
Last commit
Last update
..
hooks Loading commit data...
test Loading commit data...
annotation-action-bar.js Loading commit data...
annotation-body.js Loading commit data...
annotation-document-info.js Loading commit data...
annotation-header.js Loading commit data...
annotation-license.js Loading commit data...
annotation-publish-control.js Loading commit data...
annotation-quote.js Loading commit data...
annotation-share-control.js Loading commit data...
annotation-share-info.js Loading commit data...
annotation-user.js Loading commit data...
annotation-viewer-content.js Loading commit data...
annotation.js Loading commit data...
autocomplete-list.js Loading commit data...
button.js Loading commit data...
excerpt.js Loading commit data...
focused-mode-header.js Loading commit data...
group-list-item.js Loading commit data...
group-list-section.js Loading commit data...
group-list.js Loading commit data...
help-panel.js Loading commit data...
hypothesis-app.js Loading commit data...
logged-out-message.js Loading commit data...
login-prompt-panel.js Loading commit data...
markdown-editor.js Loading commit data...
markdown-view.js Loading commit data...
menu-item.js Loading commit data...
menu-section.js Loading commit data...
menu.js Loading commit data...
moderation-banner.js Loading commit data...
new-note-btn.js Loading commit data...
search-input.js Loading commit data...
search-status-bar.js Loading commit data...
selection-tabs.js Loading commit data...
share-annotations-panel.js Loading commit data...
share-links.js Loading commit data...
sidebar-content-error.js Loading commit data...
sidebar-content.js Loading commit data...
sidebar-panel.js Loading commit data...
slider.js Loading commit data...
sort-menu.js Loading commit data...
spinner.js Loading commit data...
stream-content.js Loading commit data...
stream-search-input.js Loading commit data...
tag-editor.js Loading commit data...
tag-list.js Loading commit data...
thread-list.js Loading commit data...
thread.js Loading commit data...
timestamp.js Loading commit data...
toast-messages.js Loading commit data...
top-bar.js Loading commit data...
tutorial.js Loading commit data...
user-menu.js Loading commit data...
version-info.js Loading commit data...