• Robert Knight's avatar
    Remove fragment anchoring support · f8784b2c
    Robert Knight authored
    dom-anchor-fragment is shipped as a UMD module which causes problems on
    pages that declare a global function called `define` (see #479).
    
    While we could fix the module, fragment anchoring is not very useful at
    the moment. The client primarily anchors to the quote and uses other
    anchors only as an optimization. The Wikipedia baseline tests changed in
    this PR show how little value a fragment has on real websites.
    Therefore, just remove support for generating and using fragment selectors.
    
    This change should not cause anchoring regressions, as anchoring would
    only have succeeded previously if the quote selector matched. Now it will just
    fall through to anchoring using the range, position or quote selectors instead.
    
    Fixes #479
    f8784b2c
Name
Last commit
Last update
..
anchoring Loading commit data...
config Loading commit data...
highlighter Loading commit data...
plugin Loading commit data...
test Loading commit data...
util Loading commit data...
.eslintrc.js Loading commit data...
adder.html Loading commit data...
adder.js Loading commit data...
annotation-counts.js Loading commit data...
annotation-sync.js Loading commit data...
delegator.coffee Loading commit data...
features.js Loading commit data...
frame-observer.js Loading commit data...
guest.coffee Loading commit data...
host.coffee Loading commit data...
index.js Loading commit data...
pdf-sidebar.js Loading commit data...
pdfjs-rendering-states.js Loading commit data...
plugin.coffee Loading commit data...
range-util.js Loading commit data...
selections.js Loading commit data...
sidebar-trigger.js Loading commit data...
sidebar.coffee Loading commit data...