• Robert Knight's avatar
    Show "Leave group" option for open and restricted groups that user is a member of · d14c255b
    Robert Knight authored
    Previously the "Leave group" option was only shown for private groups on the
    basis that membership of open and restricted groups was managed by h admins.
    However first-party Hypothesis users can now create open and restricted groups
    themselves and members of these groups will see an option to leave the group on
    activity pages. Align whether the client shows the "Leave group" option with h's
    behavior.
    
    During this change it was noticed that the documentation in the code and test
    descriptions did not match the actual handling of `allowLeavingGroups`. The
    comments said that services had to explicitly set `allowLeavingGroups` to
    prevent users leaving. However the code would treat `allowLeavingGroups` as false
    if a) service configuration was present and b) the value of `allowLeavingGroups`
    was falsey (including undefined). Changing this behavior may cause issues for
    existing users of third party authorities, so this commit updates the
    documentation and tests to accurately describe the current behavior.
    
    Fixes https://github.com/hypothesis/client/issues/6637
    d14c255b
Name
Last commit
Last update
.github Loading commit data...
.yarn Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
.readthedocs.yaml Loading commit data...
.yarnrc.yml Loading commit data...
HACKING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
eslint.config.js Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
rollup-boot.config.js Loading commit data...
rollup-tests.config.js Loading commit data...
rollup.config.js Loading commit data...
tailwind-annotator.config.js Loading commit data...
tailwind-sidebar.config.js Loading commit data...
tailwind.config.js Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...