• Eduardo Sanz García's avatar
    Use an RPC call instead of direct call to `Guest#selectAnnotations` · d4046e03
    Eduardo Sanz García authored
    We want the `BucketBar` to be able to communicate with `Guest`s that are
    in other iframes, like in the Ebook scenario. Currently, the `BucketBar`
    has an instance of the `Guest`, associated with `host` frame, and
    assumes to be the main `Guest`, for communication purposes.
    
    I have replaced the reliance of the direct invocation of
    `Guest#selectAnnotations` by a new `selectAnnotations` RPC event in the
    `guest-host` communication channel. This has the advantage of making no
    assumptions about which iframe contains the annotations.
    
    I have made some minor modification in the types and functionality of
    `range-util`.
    d4046e03
Name
Last commit
Last update
..
integration Loading commit data...
adder-test.js Loading commit data...
annotation-counts-test.js Loading commit data...
bucket-bar-client-test.js Loading commit data...
bucket-bar-test.js Loading commit data...
empty.html Loading commit data...
features-test.js Loading commit data...
frame-observer-test.js Loading commit data...
guest-test.js Loading commit data...
highlighter-test.js Loading commit data...
notebook-test.js Loading commit data...
range-util-test.js Loading commit data...
selection-observer-test.js Loading commit data...
sidebar-test.js Loading commit data...
sidebar-trigger-test.js Loading commit data...
toolbar-test.js Loading commit data...