• Robert Knight's avatar
    Extract `quote` function from annotation / view-filter · d4374884
    Robert Knight authored
    Both `components/annotation` and `view-filter` modules had logic and
    tests for extracting a quote from an annotation object. Extract these
    into a shared `quote` function in `util/annotation-metadata`.
    
    One small change is that `view-filter`'s implementation allowed
    annotation objects with _no_ `target` property. These should never
    occur. There is a known issue where creating a Page Note results in an
    annotation with an _empty_ `target` property until the annotation is
    saved (see [1]). That case, which is still handled, looks like a mistake,
    but resolving it is outside the scope of this change.
    
    [1] https://github.com/hypothesis/client/issues/1290
    d4374884
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.prettierrc Loading commit data...
.python-version Loading commit data...
.travis.yml Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
yarn.lock Loading commit data...