Skip to content

C
coopwire-hypothesis
Switch branch/tag
History Find file
  • Robert Knight's avatar
    Fix sidebar vertical toolbar button alignment · 5277df4c
    Robert Knight authored 
    The client's test page was missing a `<!DOCTYPE html>` declaration and
as a result rendered in _quirks mode_ rather than _standards mode_. This
hid an issue where the toolbar buttons were not centered correctly in
standards-mode documents.

This incorrect centering was caused by:

 1. The CSS bundle for the "annotator" part of the app not including the
    CSS styles for the `SvgIcon` component
 2. An unnecessary `padding` declaration on the `.annotator-frame-button`
    class

I haven't investigated in detail exactly which quirks-vs-standards mode
difference resulted in the centering still being OK in quirks-mode.

This commit fixes these two issues and fixes toolbar button centering in
both quirks and standards-mode documents.

It also updates the client's test page to add the `<!DOCTYPE html>`
declaration since standards mode is what most web content uses.
    5277df4c
Name
Last commit
 Last update
..
create-bundle.js Loading commit data...
create-server.js Loading commit data...
create-style-bundle.js Loading commit data...
dev-server.js Loading commit data...
manifest.js Loading commit data...
minify-stream.js Loading commit data...
serve-package.js Loading commit data...
vendor-bundles.js Loading commit data...