• Robert Knight's avatar
    Fix OAuth popup being blocked by pop-up blocker in Firefox and IE · 7be7735a
    Robert Knight authored
    When the user clicked the "Log in" link, the URL of the
    "oauth.authorize" endpoint was fetched via an async Promise-returning
    method before the `window.open` call was made. This meant that the
    `window.open` call did not happen in the turn of the event loop that was
    triggered by the user action and so Firefox & IE's popup blockers deemed
    the call to have happened outside the context of a user gesture and
    prevented the window being opened.
    
    Chrome, Safari & Edge have different heuristics and did not block the
    popup before.
    
    Fix the issue by opening the window directly when the user clicks on the
    "Log in" button, at a dummy URL ("about:blank"), and then changing the
    window's location once the authorization endpoint URL has been fetched.
    
    Fixes #534
    7be7735a
Name
Last commit
Last update
..
integration Loading commit data...
analytics-test.js Loading commit data...
annotation-fixtures.js Loading commit data...
annotation-mapper-test.js Loading commit data...
annotation-metadata-test.js Loading commit data...
annotation-ui-test.js Loading commit data...
api-routes-test.js Loading commit data...
auth-test.js Loading commit data...
bootstrap.js Loading commit data...
build-thread-test.js Loading commit data...
drafts-test.js Loading commit data...
fake-redux-store.js Loading commit data...
features-test.js Loading commit data...
flash-test.js Loading commit data...
form-respond-test.coffee Loading commit data...
frame-sync-test.js Loading commit data...
get-api-url-test.js Loading commit data...
groups-test.js Loading commit data...
host-config-test.js Loading commit data...
local-storage-test.js Loading commit data...
markdown-commands-test.js Loading commit data...
media-embedder-test.js Loading commit data...
oauth-auth-test.js Loading commit data...
permissions-test.js Loading commit data...
raven-test.js Loading commit data...
render-markdown-test.js Loading commit data...
retry-util-test.js Loading commit data...
root-thread-test.js Loading commit data...
search-client-test.js Loading commit data...
search-filter-test.js Loading commit data...
service-config-test.js Loading commit data...
service-url-test.js Loading commit data...
session-test.js Loading commit data...
store-test.js Loading commit data...
streamer-test.js Loading commit data...
tabs-test.js Loading commit data...
tags-test.js Loading commit data...
time-test.js Loading commit data...
unicode-test.js Loading commit data...
view-filter-test.coffee Loading commit data...
virtual-thread-list-test.js Loading commit data...
websocket-test.js Loading commit data...