• Lyza Danger Gardner's avatar
    Avoid using named text-size classes to set specific icon dimensions · e8f12d32
    Lyza Danger Gardner authored
    In some cases icons are sized relative to local text or containers
    (em-based sizing) and that's fine, but using a named text-size
    utility directly on an icon can add a layer of unhelpful abstraction if
    our intent is simply to size the icon to particular pixel dimensions. It
    also entangles icon sizing with text sizing in an unintended way.
    
    In cases where we want to size icons to specific dimensions,
    irrespective of local text size, use size utility classes, not text-size
    utility classes.
    
    In cases where icons use em-based sizing (e.g. we want to set a text
    size on a container such that descendant icons, which are sized at 1em,
    have desired dimensions), use arbitrary text sizing classes (e.g.
    `text-[16px]` instead of `text-lg`) to be explicit about the intent.
    e8f12d32
Name
Last commit
Last update
..
annotator Loading commit data...
boot Loading commit data...
images/icons Loading commit data...
shared Loading commit data...
sidebar Loading commit data...
styles Loading commit data...
test-util Loading commit data...
types Loading commit data...
karma.config.js Loading commit data...
tsconfig.json Loading commit data...