• Eduardo Sanz García's avatar
    Use shadow DOM to encapsulate sidebar's style · 02c32fab
    Eduardo Sanz García authored
    A side effect of using shadow DOM for the sidebar is that the BucketBar
    'plugin' could not be injected easily using a current query mechanism.
    After consulting with @robertknight, we decided to avoid using the
    normal plugin injection mechanism and instead instantiate the BucketBar
    from the sidebar.
    
    This PR also includes:
    
    - a no documented configuration option to disable the shadow DOM
      encapsulation. This can be removed in the future if not needed.
    - more strict types
    - simplification of the logic in the sidebar
    
    I have tested these changes in the following browsers:
    
    Brower\OS    | MacOS              | Windows
    ------------ | ------------------ | -----------------
    Chrome 57    |  | 
    Chrome beta  |  | 
    Edge 17      |                    | 
    Edge beta    |  | 
    Firefox 53   |  | 
    Firefox beta |  | 
    Safari 10    |  |
    Safari 14    |  |
    02c32fab
Name
Last commit
Last update
..
anchoring Loading commit data...
components Loading commit data...
config Loading commit data...
plugin Loading commit data...
test Loading commit data...
util Loading commit data...
.eslintrc.js Loading commit data...
adder.js Loading commit data...
annotation-counts.js Loading commit data...
annotation-sync.js Loading commit data...
delegator.js Loading commit data...
features.js Loading commit data...
frame-observer.js Loading commit data...
guest.js Loading commit data...
highlighter.js Loading commit data...
icons.js Loading commit data...
index.js Loading commit data...
notebook.js Loading commit data...
pdf-sidebar.js Loading commit data...
pdfjs-rendering-states.js Loading commit data...
range-util.js Loading commit data...
selection-observer.js Loading commit data...
sidebar-trigger.js Loading commit data...
sidebar.js Loading commit data...
toolbar.js Loading commit data...