• Eduardo Sanz García's avatar
    Remove `PortProvider#hostPortFrom` method · f364519b
    Eduardo Sanz García authored
    There are two methods to get the host port from `PortProvider`:
    
    - `#hostPortFrom` which returns the host port exclusively from the
      `sidebar-host` channel.
    
    - `#on` allows to register a listener that is fired upon requests
      of host frames for channels other than the `sidebar-host`.
    
    This is an attempt to simplify the API of `PortProvider` and merge both
    methods into one.
    
    Advantages:
    
    - simplifies the `Sidebar` constructor signature (no need to pass the
      host port)
    
    - avoids the pitfall of creating host-sidebar RPC channel before
      registering the RPC methods
    
    - prepares for future guest-host channel see https://github.com/hypothesis/client/blob/ad93317debdac0d2c3abec83eb9d690934632ef3/src/annotator/index.js#L64-L66 (where the `#on` method is use to create the guest-host channel).
    f364519b
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.mjs Loading commit data...
package.json Loading commit data...
pyproject.toml Loading commit data...
requirements-dev.in Loading commit data...
rollup-boot.config.mjs Loading commit data...
rollup-tests.config.mjs Loading commit data...
rollup.config.mjs Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...