• Robert Knight's avatar
    Remove unnecessary array filter · f43663c6
    Robert Knight authored
    Remove a filter callback which always returned true. The first `!ann.id`
    condition is already part of the `store.unsavedAnnotations` logic. The
    second `isHighlight(...)` check did not work properly because the input
    was an annotation stub object with only `id` and `$tag` fields instead
    of the `Annotation` that `isHighlight` expects. For annotation stubs
    with no id, it always returned false.
    
    From a functional perspective the `isHighlight` check was also
    unnecessary. `store.unsavedAnnotations()` only returns IDs of
    annotations which have active drafts, but for highlights no draft is
    created.
    f43663c6
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
requirements Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.mjs Loading commit data...
package.json Loading commit data...
pyproject.toml Loading commit data...
requirements-dev.in Loading commit data...
rollup-boot.config.mjs Loading commit data...
rollup-tests.config.mjs Loading commit data...
rollup.config.mjs Loading commit data...
tox.ini Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...