• Robert Knight's avatar
    Clarify what happens if range is outside of text layer · f6f0003f
    Robert Knight authored
    Ensure that the `describe` function in `anchoring/pdf.js` fails with a
    useful error if the passed range includes text outside of the PDF page's
    text layer. In this case `getNodeTextLayer` will return `null` and
    existing code in `describe` will throw to indicate the range starts or
    ends outside of the text layer.
    
    This will help to avoid the confusion that arose in
    https://github.com/hypothesis/client/issues/1464.
    
    This behavior is still not really useful from the end user's point of
    view, but at least the error is better. Improving the actual behavior
    will come later.
    f6f0003f
Name
Last commit
Last update
.github Loading commit data...
bin Loading commit data...
dev-server Loading commit data...
docs Loading commit data...
embedding-examples Loading commit data...
images Loading commit data...
scripts Loading commit data...
src Loading commit data...
.babelrc Loading commit data...
.dockerignore Loading commit data...
.eslintignore Loading commit data...
.eslintrc Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
.npmrc Loading commit data...
.prettierignore Loading commit data...
.prettierrc Loading commit data...
.python-version Loading commit data...
CODE_OF_CONDUCT Loading commit data...
Dockerfile Loading commit data...
Jenkinsfile Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
codecov.yml Loading commit data...
gulpfile.js Loading commit data...
package.json Loading commit data...
requirements-dev.in Loading commit data...
tox.ini Loading commit data...
yarn.lock Loading commit data...